chore: Button cruft cleanup #11342
Merged
chore: Button cruft cleanup #11342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11342 +/- ##
==========================================
- Coverage 65.75% 56.01% -9.75%
==========================================
Files 838 406 -432
Lines 39714 13562 -26152
Branches 3613 3443 -170
==========================================
- Hits 26115 7597 -18518
+ Misses 13498 5796 -7702
- Partials 101 169 +68
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mistercrunch
approved these changes
Oct 23, 2020
Member
|
I think this PR made some Actually nevermind it's #11400 |
Member
Author
Ack, then it's still my fault! And I'm still confused! Investigating... |
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* toggleSchedule * cleaning up run query button * removing unnecessary (subtle!) style overrides * bulk action classname to button style prop * nixing btn-primary * nixing cancelQuery class * togglesave * nixing autocomplete class * linting * nixing button classes of 'ok' and 'reset' * unoing diagnostic test * begrudgingly adding an m-r-3 class... for now * this is not a class to worry about * test fixes for limit control * updating TODO notes, calling it a day for now. * gah... copy paste error.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Cleaning up various unnecessary classes and such around buttons.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Most should show no significant visible difference. Screenshots of what is visible here:
A little margin between buttons (will PR a better fix for this scenario soon)
before:
after:
TEST PLAN
Made sure case by case that I didn't break anything. If I did this right, you'll likely never notice.
ADDITIONAL INFORMATION