Skip to content

fix: use dashboard id for stable cache key #11293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktmud merged 1 commit into from
Oct 16, 2020
Merged

fix: use dashboard id for stable cache key #11293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions superset/models/dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ class Dashboard( # pylint: disable=too-many-instance-attributes
]

def __repr__(self) -> str:
return f"Dashboard<{self.slug or self.id}>"
return f"Dashboard<{self.id or self.slug}>"

@property
def table_names(self) -> str:
Expand Down Expand Up @@ -253,7 +253,7 @@ def data(self) -> Dict[str, Any]:

@cache.memoize(
# manage cache version manually
make_name=lambda fname: f"{fname}-v2",
make_name=lambda fname: f"{fname}-v2.1",
timeout=config["DASHBOARD_CACHE_TIMEOUT"],
unless=lambda: not is_feature_enabled("DASHBOARD_CACHE"),
)
Expand Down