Skip to content

fix: add schema name to datasource field in chart list #11278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nytai merged 3 commits into from
Oct 15, 2020
Merged

fix: add schema name to datasource field in chart list #11278

nytai merged 3 commits into from
Oct 15, 2020

Conversation

@nytai
Copy link
Member

@nytai nytai commented Oct 14, 2020 •
edited
Loading

SUMMARY

see title and linked ticket

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2020-10-14 at 3 32 06 PM

TEST PLAN

  • CI
  • verify that schema name is rendered in dataset name for the charts list view

ADDITIONAL INFORMATION

@nytai nytai linked an issue Oct 14, 2020 that may be closed by this pull request
Dataset in Chart CRUD view no longer include schema name #11265
Closed
@codecov-io
Copy link

codecov-io commented Oct 14, 2020 •
edited
Loading

Codecov Report

Merging #11278 into master will decrease coverage by 9.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11278      +/-   ##
==========================================
- Coverage   65.43%   55.96%   -9.48%     
==========================================
  Files         831      404     -427     
  Lines       39528    13410   -26118     
  Branches     3598     3392     -206     
==========================================
- Hits        25866     7505   -18361     
+ Misses      13553     5723    -7830     
- Partials      109      182      +73
Flag Coverage Δ
#cypress 55.96% <ø> (+<0.01%) ⬆️
#javascript ?
#python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...rc/dashboard/util/getLayoutComponentFromChartId.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx 3.57% <0.00%> (-93.73%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...uperset-frontend/src/utils/getClientErrorObject.ts 0.00% <0.00%> (-89.19%) ⬇️
.../src/dashboard/components/FilterIndicatorGroup.jsx 11.76% <0.00%> (-88.24%) ⬇️
...c/explore/components/controls/withVerification.jsx 9.09% <0.00%> (-87.88%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
... and 666 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 634676d...d67a822. Read the comment docs.

@nytai nytai marked this pull request as ready for review October 15, 2020 00:44
etr2460
etr2460 approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix! one comment (non-blocking)

superset/models/slice.py Outdated
if self.table.schema:
return f"{self.table.schema}.{self.table.table_name}"
return self.table.table_name
datasource = self.datasource
Copy link
Member

@etr2460 etr2460 Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why we have this here if we're not handling self.table the same way?

I don't really care which we do, but let's be consistent (either table and datasource or self.table and self.datasource)

Copy link
Member Author

@nytai nytai Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like most methods in this model share this inconsistency 😕

@nytai nytai merged commit 233e67a into apache:master Oct 15, 2020
@nytai nytai deleted the tai/crud-cleanup branch October 15, 2020 21:12
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@nytai @auxten
fix: add schema name to datasource field in chart list (apache#11278)
77e6f9b
@laxmanraparthi laxmanraparthi mentioned this pull request Jun 28, 2023
Open
This was referenced Nov 26, 2023
Open
Open
Open
@m-ajay m-ajay mentioned this pull request Nov 28, 2023
Open
This was referenced Dec 14, 2023
Open
Open
This was referenced Dec 20, 2023
Open
Open
@matrix-compute matrix-compute mentioned this pull request Dec 26, 2023
Open
@laxmanraparthi laxmanraparthi mentioned this pull request Jan 2, 2024
Open
@matrix-compute matrix-compute mentioned this pull request Feb 16, 2024
Open
@matrix-compute matrix-compute mentioned this pull request Mar 11, 2024
Merged
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 First shipped in 1.0.0 labels Mar 12, 2024
@laxmanraparthi laxmanraparthi mentioned this pull request Mar 15, 2024
Open
@matrix-compute matrix-compute mentioned this pull request Mar 23, 2024
Open
@matrix-compute matrix-compute mentioned this pull request May 14, 2024
Open
@matrix-compute matrix-compute mentioned this pull request May 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etr2460 etr2460 etr2460 approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0 First shipped in 1.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dataset in Chart CRUD view no longer include schema name

4 participants

@nytai @codecov-io @etr2460 @mistercrunch