Skip to content

fix: delete the correct dashboard cache key #11273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etr2460 merged 2 commits into from
Oct 14, 2020
Merged

fix: delete the correct dashboard cache key #11273

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13b9039
bugfix: delete dashboard cache key correctly
ktmud Oct 14, 2020
ed9a7a0
update version number
ktmud Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions superset/models/dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,7 @@ def data(self) -> Dict[str, Any]:
}

@cache.memoize(
# manually maintain cache key version
make_name=lambda fname: f"{fname}-v1",
make_name=lambda fname: f"{fname}-v0.1",

@etr2460 etr2460 Oct 14, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not v2?

@ktmud ktmud Oct 14, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that works, too. Just thought this feature is still unstable so let's start with something small.

@etr2460 etr2460 Oct 14, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough

timeout=config["DASHBOARD_CACHE_TIMEOUT"],
unless=lambda: not is_feature_enabled("DASHBOARD_CACHE"),
)
Expand Down Expand Up @@ -294,7 +293,7 @@ def update_thumbnail(self) -> None:

@debounce(0.1)
def clear_cache(self) -> None:
cache.delete_memoized(self.full_data)

@ktmud ktmud Oct 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original code only updates the hash version related to the function: https://github.com/sh4nks/flask-caching/blob/v1.9.0/flask_caching/__init__.py#L1051-L1052

cache.delete_memoized(Dashboard.full_data, self)

@classmethod
@debounce(0.1)
Expand Down