Skip to content

fix: button translations missing #11187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mistercrunch merged 2 commits into from
Oct 16, 2020
Merged

fix: button translations missing #11187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc21229
button translations missing
rubenSastre Oct 7, 2020
d49b196
blank space before text
rubenSastre Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset-frontend/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ describe('QueryAndSaveButtons', () => {

it('renders buttons with correct text', () => {
expect(wrapper.find(Button).contains('Run')).toBe(true);
expect(wrapper.find(Button).contains(' Save')).toBe(true);
expect(wrapper.find(Button).contains('Save')).toBe(true);
});

it('calls onQuery when query button is clicked', () => {
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/src/components/Menu/Menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ export function Menu({
<Nav className="navbar-right">
{!navbarRight.user_is_anonymous && <NewMenu />}
{settings && settings.length > 0 && (
<NavDropdown id="settings-dropdown" title="Settings">
<NavDropdown id="settings-dropdown" title={t('Settings')}>
{flatSettings.map((section, index) => {
if (section === '-') {
return (
Expand Down
6 changes: 3 additions & 3 deletions superset-frontend/src/dashboard/components/PublishedStatus.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export default class PublishedStatus extends React.Component {
this.togglePublished();
}}
>
Draft
{t('Draft')}
</Label>
</TooltipWrapper>
);
Expand All @@ -80,7 +80,7 @@ export default class PublishedStatus extends React.Component {
placement="bottom"
tooltip={draftDivTooltip}
>
<Label>Draft</Label>
<Label>{t('Draft')}</Label>
</TooltipWrapper>
);
}
Expand All @@ -98,7 +98,7 @@ export default class PublishedStatus extends React.Component {
this.togglePublished();
}}
>
Published
{t('Published')}
</Label>
</TooltipWrapper>
);
Expand Down
4 changes: 2 additions & 2 deletions superset-frontend/src/explore/components/QueryAndSaveBtns.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export default function QueryAndSaveBtns({
buttonSize="small"
disabled={!canAdd}
>
<i className="fa fa-stop-circle-o" /> Stop
<i className="fa fa-stop-circle-o" /> {t('Stop')}
</Button>
) : (
<Button
Expand All @@ -115,7 +115,7 @@ export default function QueryAndSaveBtns({
disabled={saveButtonDisabled}
onClick={onSave}
>
<i className="fa fa-plus-circle" /> Save
<i className="fa fa-plus-circle" /> {t('Save')}
</Button>
</ButtonGroup>
{errorMessage && (
Expand Down
4 changes: 2 additions & 2 deletions superset/templates/appbuilder/general/widgets/search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
</table>
<div class="filter-action" style="display:none">
<button type="submit" class="btn btn-sm btn-primary" id="search-action">
Search&nbsp;&nbsp;<i class="fa fa-search"></i>
{{_("Search")}}&nbsp;&nbsp;<i class="fa fa-search"></i>
</button>
</div>
</div>
Expand All @@ -54,7 +54,7 @@
$('.filter-action').toggle(true);
} else {
$('.filter-action').toggle(true);
$('.filter-action > button').html('Refresh&nbsp;&nbsp;<i class="fa fa-refresh"></i>');
$('.filter-action > button').html('{{_("Refresh")}}&nbsp;&nbsp;<i class="fa fa-refresh"></i>');
}
}

Expand Down
1 change: 1 addition & 0 deletions superset/views/dashboard/mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ class DashboardMixin: # pylint: disable=too-few-public-methods
"slug": _("Slug"),
"charts": _("Charts"),
"owners": _("Owners"),
"published": _("Published"),
"creator": _("Creator"),
"modified": _("Modified"),
"position_json": _("Position JSON"),
Expand Down