Skip to content

Conversation

@mistercrunch
Copy link
Member

@xrmx
Copy link
Contributor

xrmx commented Sep 15, 2016

Am a bit puzzled about the second picture but the third looks good to me

@ascott
Copy link

ascott commented Sep 15, 2016

i agree that 6/6 split on the grid for the header doesn't give it much room for longer titles, however i think the pull-left/right introduces another problem. the third screenshot here does not have good hierarchy or spacing between the title and the explore actions. also, what happens if that title is even longer? how does it wrap?

i would recommend sticking with the grid, and using col-7/col-5 as a split between title and action buttons, and also bumping the title to h3 rather than changing the font size of h2.

before:
screenshot 2016-09-15 14 04 25

after:
screenshot 2016-09-15 14 02 49
screenshot 2016-09-15 14 03 52

@elibrumbaugh, any thoughts on this?

@xrmx
Copy link
Contributor

xrmx commented Sep 16, 2016

@ascott h3 + 7/5 will fit the longest title i have here but not the star and edit icons. 8/4 split would be too much?

@mistercrunch
Copy link
Member Author

well then the right controls wrap at smaller widths which is worse
screen shot 2016-09-16 at 10 03 23 am

@mistercrunch
Copy link
Member Author

I moved h2->h3, I think it looks better than before so I'll merge this for now. We can revisit if needed.

@mistercrunch mistercrunch merged commit e8f1bab into apache:master Sep 16, 2016
@mistercrunch mistercrunch deleted the pull branch September 16, 2016 22:41
dennisobrien pushed a commit to dennisobrien/caravel that referenced this pull request Sep 19, 2016
* [explore] giving more room to Slice title

* h2->h3 for slice title
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 First shipped in 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 First shipped in 0.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants