ESLint: Re-enable rule prefer-destructuring (only for objects) #10867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
approved these changes
Sep 14, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
8 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Re-enable ESLint rule
prefer-destructuring, which was disabled in PR #10839. I kept the rule disabled for arrays, because I think the destructuring syntax was less readable - e.g.newValue = newValue[0]versus[newValue, ,] = newValue(occurs in fileMetricsControl.jsx). Code was refactored to fix the errors raised by the rule.TEST PLAN
Run
npm run lint, verify that there are no new Javascript/Typescript errors.ADDITIONAL INFORMATION