Skip to content

test: add rls jinja extra cache key test #10810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
villebro merged 1 commit into from
Sep 8, 2020
Merged

test: add rls jinja extra cache key test #10810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tests/security_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,7 +1020,7 @@ def setUp(self):
.filter(SqlaTable.table_name.in_(["energy_usage", "unicode_test"]))
.all()
)
self.rls_entry.clause = "value > 1"
self.rls_entry.clause = "value > {{ cache_key_wrapper(1) }}"
self.rls_entry.roles.append(
security_manager.find_role("Gamma")
) # db.session.query(Role).filter_by(name="Gamma").first())
Expand Down Expand Up @@ -1052,7 +1052,8 @@ def test_rls_filter_alters_query(self):
extras={},
)
sql = tbl.get_query_str(query_obj)
self.assertIn("value > 1", sql)
assert tbl.get_extra_cache_keys(query_obj) == [1]
assert "value > 1" in sql

def test_rls_filter_doesnt_alter_query(self):
g.user = self.get_user(
Expand All @@ -1071,7 +1072,8 @@ def test_rls_filter_doesnt_alter_query(self):
extras={},
)
sql = tbl.get_query_str(query_obj)
self.assertNotIn("value > 1", sql)
assert tbl.get_extra_cache_keys(query_obj) == []
assert "value > 1" not in sql

def test_multiple_table_filter_alters_another_tables_query(self):
g.user = self.get_user(
Expand All @@ -1090,4 +1092,5 @@ def test_multiple_table_filter_alters_another_tables_query(self):
extras={},
)
sql = tbl.get_query_str(query_obj)
self.assertIn("value > 1", sql)
assert tbl.get_extra_cache_keys(query_obj) == [1]
assert "value > 1" in sql