Skip to content

Fix: Include RLS filters for cache keys #10805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
villebro merged 2 commits into from
Sep 7, 2020
Merged

Fix: Include RLS filters for cache keys #10805

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c8a50a
Fix: Include RLS filters for cache keys
gtg472b Sep 6, 2020
4f6d57d
Fix: Include RLS filters for cache keys
gtg472b Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions superset/connectors/sqla/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1454,6 +1454,11 @@ def has_extra_cache_key_calls(self, query_obj: QueryObjectDict) -> bool:
templatable_statements.append(extras["where"])
if "having" in extras:
templatable_statements.append(extras["having"])
# make sure the RLS filters are included
if config["ENABLE_ROW_LEVEL_SECURITY"] and self.is_rls_supported:
templatable_statements += [
f.clause
for f in security_manager.get_rls_filters(self) ]
Comment thread
gtg472b marked this conversation as resolved.
Outdated
for statement in templatable_statements:
if ExtraCache.regex.search(statement):
return True
Expand Down