feat: Getting fancier with Storybook #10647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
approved these changes
Aug 20, 2020
Member
etr2460
left a comment
etr2460
left a comment
There was a problem hiding this comment.
a couple questions, otherwise lgtm
amitmiran137
pushed a commit
to amitmiran137/incubator-superset
that referenced
this pull request
Aug 21, 2020
* master: (43 commits) feat: Getting fancier with Storybook (apache#10647) fix: dedup groupby in viz.py while preserving order (apache#10633) feat: bump superset-ui for certified tag (apache#10650) feat: setup react page with submenu for datasources listview (apache#10642) feat: add certification to metrics (apache#10630) feat(viz-plugins): add date formatting to pivot-table (apache#10637) fix: controls scroll issue (apache#10644) feat: Allow tests files in /src (plus Label component tests) (apache#10634) fix: remove duplicated params and cache_timeout from list_columns; add viz_type to list_columns (apache#10643) chore: splitting button stories into separate stories (apache#10631) refactor: remove slice level label_colors from dashboard init load (apache#10603) feat: card view bulk select (apache#10607) style: Label styling/storybook touchups (apache#10627) fix: removing unsupported modal sizes (apache#10625) feat(datasource): remove deleted columns and update column type on metadata refresh (apache#10619) improve documentation for country maps (apache#10621) chore: npm audit fix as of 2020-08-15 (apache#10613) feat: dataset REST API for distinct values (apache#10595) chore: bump react-redux to 5.1.2, whittling console noise (apache#10602) fixing console error about bad html attribute (apache#10604) ... # Conflicts: # superset-frontend/src/explore/components/ExploreViewContainer.jsx # superset-frontend/src/views/App.tsx # superset/config.py
villebro
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 11, 2020
* Niftier paddings * upgrading storybook, fixing glob pattern * moving a couple storybook dependencies to dev dependencies * fixing annoying lint issue about dev dependencies needing to be dependencies * adds essential addons, fixes backgrounds * newline tweaks * comment about no-extraneous-dependencies, higher specificity on that rule, other linting stuff * a *python* linter doesn't like this whitespace?! * putting the linespace back * ugh, found the space causing CI issues... I think
villebro
pushed a commit
that referenced
this pull request
Sep 11, 2020
* Niftier paddings * upgrading storybook, fixing glob pattern * moving a couple storybook dependencies to dev dependencies * fixing annoying lint issue about dev dependencies needing to be dependencies * adds essential addons, fixes backgrounds * newline tweaks * comment about no-extraneous-dependencies, higher specificity on that rule, other linting stuff * a *python* linter doesn't like this whitespace?! * putting the linespace back * ugh, found the space causing CI issues... I think
Ofeknielsen
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Oct 5, 2020
* Niftier paddings * upgrading storybook, fixing glob pattern * moving a couple storybook dependencies to dev dependencies * fixing annoying lint issue about dev dependencies needing to be dependencies * adds essential addons, fixes backgrounds * newline tweaks * comment about no-extraneous-dependencies, higher specificity on that rule, other linting stuff * a *python* linter doesn't like this whitespace?! * putting the linespace back * ugh, found the space causing CI issues... I think
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* Niftier paddings * upgrading storybook, fixing glob pattern * moving a couple storybook dependencies to dev dependencies * fixing annoying lint issue about dev dependencies needing to be dependencies * adds essential addons, fixes backgrounds * newline tweaks * comment about no-extraneous-dependencies, higher specificity on that rule, other linting stuff * a *python* linter doesn't like this whitespace?! * putting the linespace back * ugh, found the space causing CI issues... I think
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This plugin does a number of things for Storybook, namely:
• Upgrades storybook to the latest major version (and adds tweaks to make it work)
• Includes a nifty add-on for various padding options in display area
• Essential addons for background selection, grid display, and viewport sizing
• Adjustments to existing stories for all of the above
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Well, the storybook kind of IS the test here.
ADDITIONAL INFORMATION