Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deckgl dimension select missing options #10277

Merged
merged 1 commit into from
Jul 10, 2020
Merged

fix: deckgl dimension select missing options #10277

merged 1 commit into from
Jul 10, 2020

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Jul 9, 2020

SUMMARY

Fix Bug #10246 introduced by #9455 and #9628 .

Also moved color picker to its own row so to give more space for dimension select.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TEST PLAN

  • Manual testing
  • Go create a Deck.gl Arc or Deck.gl Scatter chart

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@ktmud
Copy link
Member Author

ktmud commented Jul 9, 2020

cc @eugeniamz

villebro
villebro approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@ktmud ktmud merged commit af864e9 into apache:master Jul 10, 2020
@ktmud ktmud deleted the bugfix-deckgl branch July 10, 2020 01:27
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@ktmud @auxten
fix: deckgl dimension select missing options (apache#10277)
d2e6bb4 
Fixes apache#10246
@wildsonc wildsonc mentioned this pull request Nov 28, 2020
Closed
@sashankpappu
Copy link

Still seeing the same issue . Can you let me know if we need to change anything ?

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@rusackas rusackas Awaiting requested review from rusackas

@kristw kristw Awaiting requested review from kristw

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v0.37 🚢 0.37.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ktmud @sashankpappu @villebro @mistercrunch