Skip to content

Conversation

@ascott
Copy link

@ascott ascott commented Aug 24, 2016

  • subtle rounded corner for buttons? try 2px.
  • For the top naviation bar, use a 4 pixel underline to highlight which tab is active
  • use airpal blue for link color
  • use blue from airpal as primary btn color
  • make default btns use light bg and gray text

screenshot 2016-08-24 19 30 42

screenshot 2016-08-24 19 32 25

screenshot 2016-08-24 19 32 33

plz review @mistercrunch @bkyryliuk @elibrumbaugh

@mistercrunch
Copy link
Member

Can we keep the default button dark on light background? (black on light-gray?)

On the explore view we should use btn-primary only on the query button I think. Side note, the timer should become a label left of the button group.

Getting subjective here: what about a darker blue? Close to Github's blue maybe?

@ascott
Copy link
Author

ascott commented Aug 24, 2016

i think i prefer the airpal blue over the github blue. github blue looks too much like FB blue, and i really like that we are tying the airpal primary color over to caravel. it's nice and bright, and works well as a highlight color.

screenshot 2016-08-24 14 15 15

screenshot 2016-08-24 11 27 43

@ascott
Copy link
Author

ascott commented Aug 24, 2016

here is the explore page with dark default buttons and brighter primary for the query button.

screenshot 2016-08-24 14 18 33

@mistercrunch
Copy link
Member

mistercrunch commented Aug 24, 2016

I stacked a commit on top of your changes here, mostly dealing with a blank btn-default and using it in explore view. Oh and I moved the timer to a label.
#1010

@ascott
Copy link
Author

ascott commented Aug 24, 2016

can we finish discussing the changes in this pr and make the timer changes another PR?

@ascott
Copy link
Author

ascott commented Aug 24, 2016

i'm not sure what you mean by blank btn-default @mistercrunch

@ascott
Copy link
Author

ascott commented Aug 24, 2016

feedback from @elibrumbaugh

  • let's use the brighter airpal blue
  • let's nudge the stroke on hover on the nav bar up into the white bg part of the nav bar

@mistercrunch
Copy link
Member

blank btn-default :
screen shot 2016-08-24 at 2 54 19 pm

@mistercrunch
Copy link
Member

mistercrunch commented Aug 24, 2016

I prefer light over black background btn-default

@ascott
Copy link
Author

ascott commented Aug 25, 2016

made changes based on feedback. thanks for the review @mistercrunch @elibrumbaugh!

@ascott ascott merged commit de39923 into apache:master Aug 25, 2016
@ascott ascott deleted the ascott-btn-colors branch August 25, 2016 05:28
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 First shipped in 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 First shipped in 0.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants