-
Notifications
You must be signed in to change notification settings - Fork 16.6k
[ui] design review changes - default/primary btn colors #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can we keep the default button dark on light background? (black on light-gray?) On the explore view we should use btn-primary only on the query button I think. Side note, the timer should become a label left of the button group. Getting subjective here: what about a darker blue? Close to Github's blue maybe? |
|
I stacked a commit on top of your changes here, mostly dealing with a blank btn-default and using it in explore view. Oh and I moved the timer to a label. |
|
can we finish discussing the changes in this pr and make the timer changes another PR? |
|
i'm not sure what you mean by blank btn-default @mistercrunch |
|
feedback from @elibrumbaugh
|
|
I prefer light over black background btn-default |
|
made changes based on feedback. thanks for the review @mistercrunch @elibrumbaugh! |




plz review @mistercrunch @bkyryliuk @elibrumbaugh