Refactoring as per review comments

Improved conditional statement
apache · May 11, 2023 · c5a6c8c · c5a6c8c
1 parent 9f30967
commit c5a6c8c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/superset-frontend/packages/superset-ui-chart-controls/src/components/ColumnOption.tsx b/superset-frontend/packages/superset-ui-chart-controls/src/components/ColumnOption.tsx
@@ -63,14 +63,16 @@ export function ColumnOption({
 
   return (
     <StyleOverrides>
-      {showType && (
+      {showType && type !== undefined && (
         <Tooltip
           id="metric-type-tooltip"
           title={columnTypeTooltipText}
           placement="bottomRight"
           align={{ offset: [8, -2] }}
         >
-          <span>{type !== undefined && <ColumnTypeLabel type={type} />}</span>
+          <span>
+            <ColumnTypeLabel type={type} />
+          </span>
         </Tooltip>
       )}
       <Tooltip id="metric-name-tooltip" title={tooltipText}>