HTTP protocol implementation: allow to configure which protocol version(s) to use #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on(s) to use implements apache#827 - configuration key `http.protocol.versions` holds a list of protocols in order of preference - implement selection of protocols in okhttp protocol implementation - fix loading of YAML lists when configuration isn't loaded via Storm (eg. by main method of AbstractHttpProtocol)
Contributor
|
nice one thanks @sebastian-nagel |
Contributor
Author
|
Done: updated https://github.com/DigitalPebble/storm-crawler/wiki/Protocols, the warc module README is already updated by this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #827
http.protocol.versionsholds a list of protocols in order of preference