Add simple basic auth system

[pxtxs]

Hello,

This is a simple basic auth system that allow user to add these parameters into the yaml configuration :

• http.basicauth.enabled: true
• http.basicauth.user: "root"
• http.basicauth.password: "root"

This way it allows stormcrawler to be used in most of the intranets.

If this PR is accepted I'll produce the associated documentation .

Thanks

[jnioche]

Thanks for this PR, see comments

[jnioche]

Thanks for the PR, much appreciated.

[jnioche]

I'd rather we relied on non-shaded dependencies - snakeyaml is in our pom already - or even better on the standard Java classes e.g. https://docs.oracle.com/javase/8/docs/api/java/util/Base64.Encoder.html

[jnioche]

Instead of having a separate configuration for activating or deactivating the authentication, what about checking if http.basicauth.user is not null? If it is set, we use it. That would keep things simpler.

[pxtxs]

Thanks for the review, I adjusted the code accordingly,
Also, I modified the logic to allow user to set an empty password if necessary.

[jnioche]

Thanks @pierrehts. I have modified https://github.com/DigitalPebble/storm-crawler/wiki/Protocols to indicate that httpclient has a mechanism for basic authentication. I can give you write access to the WIKI if you want to update https://github.com/DigitalPebble/storm-crawler/wiki/Configuration.
Would be great to add the same mechanism to the okhttp implementation, would you be interested in having a look at that?
Thanks again

[pxtxs]

Thanks for accepting the PR.

Please, give me write access to the WIKI, I'll produce documentation for the new properties.
And yes, I'll implement this into okhttp as soon as I have some free time.

[jnioche]

Hi @pierrehts, have sent you an invite to become a collaborator. You should be able to write to the WIKI after that.
Thanks for documenting the new properties.
BTW if you are using StormCrawler for an organisation, why not add it to https://github.com/DigitalPebble/storm-crawler/wiki/Powered-By?