Skip to content

STORM-3862 HdfsBlobStoreImpl should check permission after mkdirs #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agresch merged 1 commit into from
May 16, 2022
Merged

STORM-3862 HdfsBlobStoreImpl should check permission after mkdirs #3478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...storm-hdfs-blobstore/src/main/java/org/apache/storm/hdfs/blobstore/HdfsBlobStoreFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,11 @@ public OutputStream getOutputStream() throws IOException {
if (!fileSystem.mkdirs(path.getParent(), dirperms)) {
LOG.warn("error creating parent dir: " + path.getParent());
}
if (!fileSystem.getFileStatus(path.getParent()).getPermission().equals(dirperms)) {
LOG.warn("Directory {} created with unexpected permission {}.Set permission {} for this directory.",
path.getParent(), fileSystem.getFileStatus(path.getParent()).getPermission(), dirperms);
fileSystem.setPermission(path.getParent(), dirperms);
}
out = fileSystem.create(path, (short) this.getMetadata().get_replication_factor());
fileSystem.setPermission(path, dirperms);
fileSystem.setReplication(path, (short) this.getMetadata().get_replication_factor());
Expand Down
5 changes: 5 additions & 0 deletions ...storm-hdfs-blobstore/src/main/java/org/apache/storm/hdfs/blobstore/HdfsBlobStoreImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,11 @@ public HdfsBlobStoreImpl(Path path, Map<String, Object> conf,
if (!fileSystem.exists(fullPath)) {
FsPermission perms = new FsPermission(BLOBSTORE_DIR_PERMISSION);
boolean success = fileSystem.mkdirs(fullPath, perms);
if (!fileSystem.getFileStatus(fullPath).getPermission().equals(perms)) {
LOG.warn("Directory {} created with unexpected permission {}.Set permission {} for this directory.",
fullPath, fileSystem.getFileStatus(fullPath).getPermission(), perms);
fileSystem.setPermission(fullPath, perms);
}
if (!success) {
throw new IOException("Error creating blobstore directory: " + fullPath);
}
Expand Down