-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-11954][SQL] Encoder for JavaBeans #9937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,14 +17,20 @@ | |
|
|
||
| package org.apache.spark.sql.catalyst | ||
|
|
||
| import java.beans.Introspector | ||
| import java.beans.{PropertyDescriptor, Introspector} | ||
| import java.lang.{Iterable => JIterable} | ||
| import java.util.{Iterator => JIterator, Map => JMap} | ||
| import java.util.{Iterator => JIterator, Map => JMap, List => JList} | ||
|
|
||
| import scala.language.existentials | ||
|
|
||
| import com.google.common.reflect.TypeToken | ||
|
|
||
| import org.apache.spark.sql.types._ | ||
| import org.apache.spark.sql.catalyst.expressions._ | ||
| import org.apache.spark.sql.catalyst.analysis.{UnresolvedAttribute, UnresolvedExtractValue} | ||
| import org.apache.spark.sql.catalyst.util.{GenericArrayData, ArrayBasedMapData, DateTimeUtils} | ||
| import org.apache.spark.unsafe.types.UTF8String | ||
|
|
||
|
|
||
| /** | ||
| * Type-inference utilities for POJOs and Java collections. | ||
|
|
@@ -33,13 +39,14 @@ object JavaTypeInference { | |
|
|
||
| private val iterableType = TypeToken.of(classOf[JIterable[_]]) | ||
| private val mapType = TypeToken.of(classOf[JMap[_, _]]) | ||
| private val listType = TypeToken.of(classOf[JList[_]]) | ||
| private val iteratorReturnType = classOf[JIterable[_]].getMethod("iterator").getGenericReturnType | ||
| private val nextReturnType = classOf[JIterator[_]].getMethod("next").getGenericReturnType | ||
| private val keySetReturnType = classOf[JMap[_, _]].getMethod("keySet").getGenericReturnType | ||
| private val valuesReturnType = classOf[JMap[_, _]].getMethod("values").getGenericReturnType | ||
|
|
||
| /** | ||
| * Infers the corresponding SQL data type of a JavaClean class. | ||
| * Infers the corresponding SQL data type of a JavaBean class. | ||
| * @param beanClass Java type | ||
| * @return (SQL data type, nullable) | ||
| */ | ||
|
|
@@ -58,6 +65,8 @@ object JavaTypeInference { | |
| (c.getAnnotation(classOf[SQLUserDefinedType]).udt().newInstance(), true) | ||
|
|
||
| case c: Class[_] if c == classOf[java.lang.String] => (StringType, true) | ||
| case c: Class[_] if c == classOf[Array[Byte]] => (BinaryType, true) | ||
|
|
||
| case c: Class[_] if c == java.lang.Short.TYPE => (ShortType, false) | ||
| case c: Class[_] if c == java.lang.Integer.TYPE => (IntegerType, false) | ||
| case c: Class[_] if c == java.lang.Long.TYPE => (LongType, false) | ||
|
|
@@ -87,15 +96,14 @@ object JavaTypeInference { | |
| (ArrayType(dataType, nullable), true) | ||
|
|
||
| case _ if mapType.isAssignableFrom(typeToken) => | ||
| val typeToken2 = typeToken.asInstanceOf[TypeToken[_ <: JMap[_, _]]] | ||
| val mapSupertype = typeToken2.getSupertype(classOf[JMap[_, _]]) | ||
| val keyType = elementType(mapSupertype.resolveType(keySetReturnType)) | ||
| val valueType = elementType(mapSupertype.resolveType(valuesReturnType)) | ||
| val (keyType, valueType) = mapKeyValueType(typeToken) | ||
| val (keyDataType, _) = inferDataType(keyType) | ||
| val (valueDataType, nullable) = inferDataType(valueType) | ||
| (MapType(keyDataType, valueDataType, nullable), true) | ||
|
|
||
| case _ => | ||
| // TODO: we should only collect properties that have getter and setter. However, some tests | ||
| // pass in scala case class as java bean class which doesn't have getter and setter. | ||
| val beanInfo = Introspector.getBeanInfo(typeToken.getRawType) | ||
| val properties = beanInfo.getPropertyDescriptors.filterNot(_.getName == "class") | ||
| val fields = properties.map { property => | ||
|
|
@@ -107,11 +115,294 @@ object JavaTypeInference { | |
| } | ||
| } | ||
|
|
||
| private def getJavaBeanProperties(beanClass: Class[_]): Array[PropertyDescriptor] = { | ||
| val beanInfo = Introspector.getBeanInfo(beanClass) | ||
| beanInfo.getPropertyDescriptors | ||
| .filter(p => p.getReadMethod != null && p.getWriteMethod != null) | ||
| } | ||
|
|
||
| private def elementType(typeToken: TypeToken[_]): TypeToken[_] = { | ||
| val typeToken2 = typeToken.asInstanceOf[TypeToken[_ <: JIterable[_]]] | ||
| val iterableSupertype = typeToken2.getSupertype(classOf[JIterable[_]]) | ||
| val iteratorType = iterableSupertype.resolveType(iteratorReturnType) | ||
| val itemType = iteratorType.resolveType(nextReturnType) | ||
| itemType | ||
| val iterableSuperType = typeToken2.getSupertype(classOf[JIterable[_]]) | ||
| val iteratorType = iterableSuperType.resolveType(iteratorReturnType) | ||
| iteratorType.resolveType(nextReturnType) | ||
| } | ||
|
|
||
| private def mapKeyValueType(typeToken: TypeToken[_]): (TypeToken[_], TypeToken[_]) = { | ||
| val typeToken2 = typeToken.asInstanceOf[TypeToken[_ <: JMap[_, _]]] | ||
| val mapSuperType = typeToken2.getSupertype(classOf[JMap[_, _]]) | ||
| val keyType = elementType(mapSuperType.resolveType(keySetReturnType)) | ||
| val valueType = elementType(mapSuperType.resolveType(valuesReturnType)) | ||
| keyType -> valueType | ||
| } | ||
|
|
||
| /** | ||
| * Returns the Spark SQL DataType for a given java class. Where this is not an exact mapping | ||
| * to a native type, an ObjectType is returned. | ||
| * | ||
| * Unlike `inferDataType`, this function doesn't do any massaging of types into the Spark SQL type | ||
| * system. As a result, ObjectType will be returned for things like boxed Integers. | ||
| */ | ||
| private def inferExternalType(cls: Class[_]): DataType = cls match { | ||
| case c if c == java.lang.Boolean.TYPE => BooleanType | ||
| case c if c == java.lang.Byte.TYPE => ByteType | ||
| case c if c == java.lang.Short.TYPE => ShortType | ||
| case c if c == java.lang.Integer.TYPE => IntegerType | ||
| case c if c == java.lang.Long.TYPE => LongType | ||
| case c if c == java.lang.Float.TYPE => FloatType | ||
| case c if c == java.lang.Double.TYPE => DoubleType | ||
| case c if c == classOf[Array[Byte]] => BinaryType | ||
| case _ => ObjectType(cls) | ||
| } | ||
|
|
||
| /** | ||
| * Returns an expression that can be used to construct an object of java bean `T` given an input | ||
| * row with a compatible schema. Fields of the row will be extracted using UnresolvedAttributes | ||
| * of the same name as the constructor arguments. Nested classes will have their fields accessed | ||
| * using UnresolvedExtractValue. | ||
| */ | ||
| def constructorFor(beanClass: Class[_]): Expression = { | ||
| constructorFor(TypeToken.of(beanClass), None) | ||
| } | ||
|
|
||
| private def constructorFor(typeToken: TypeToken[_], path: Option[Expression]): Expression = { | ||
| /** Returns the current path with a sub-field extracted. */ | ||
| def addToPath(part: String): Expression = path | ||
| .map(p => UnresolvedExtractValue(p, expressions.Literal(part))) | ||
| .getOrElse(UnresolvedAttribute(part)) | ||
|
|
||
| /** Returns the current path or `BoundReference`. */ | ||
| def getPath: Expression = path.getOrElse(BoundReference(0, inferDataType(typeToken)._1, true)) | ||
|
|
||
| typeToken.getRawType match { | ||
| case c if !inferExternalType(c).isInstanceOf[ObjectType] => getPath | ||
|
|
||
| case c if c == classOf[java.lang.Short] => | ||
| NewInstance(c, getPath :: Nil, propagateNull = true, ObjectType(c)) | ||
| case c if c == classOf[java.lang.Integer] => | ||
| NewInstance(c, getPath :: Nil, propagateNull = true, ObjectType(c)) | ||
| case c if c == classOf[java.lang.Long] => | ||
| NewInstance(c, getPath :: Nil, propagateNull = true, ObjectType(c)) | ||
| case c if c == classOf[java.lang.Double] => | ||
| NewInstance(c, getPath :: Nil, propagateNull = true, ObjectType(c)) | ||
| case c if c == classOf[java.lang.Byte] => | ||
| NewInstance(c, getPath :: Nil, propagateNull = true, ObjectType(c)) | ||
| case c if c == classOf[java.lang.Float] => | ||
| NewInstance(c, getPath :: Nil, propagateNull = true, ObjectType(c)) | ||
| case c if c == classOf[java.lang.Boolean] => | ||
| NewInstance(c, getPath :: Nil, propagateNull = true, ObjectType(c)) | ||
|
|
||
| case c if c == classOf[java.sql.Date] => | ||
| StaticInvoke( | ||
| DateTimeUtils, | ||
| ObjectType(c), | ||
| "toJavaDate", | ||
| getPath :: Nil, | ||
| propagateNull = true) | ||
|
|
||
| case c if c == classOf[java.sql.Timestamp] => | ||
| StaticInvoke( | ||
| DateTimeUtils, | ||
| ObjectType(c), | ||
| "toJavaTimestamp", | ||
| getPath :: Nil, | ||
| propagateNull = true) | ||
|
|
||
| case c if c == classOf[java.lang.String] => | ||
| Invoke(getPath, "toString", ObjectType(classOf[String])) | ||
|
|
||
| case c if c == classOf[java.math.BigDecimal] => | ||
| Invoke(getPath, "toJavaBigDecimal", ObjectType(classOf[java.math.BigDecimal])) | ||
|
|
||
| case c if c.isArray => | ||
| val elementType = c.getComponentType | ||
| val primitiveMethod = elementType match { | ||
| case c if c == java.lang.Boolean.TYPE => Some("toBooleanArray") | ||
| case c if c == java.lang.Byte.TYPE => Some("toByteArray") | ||
| case c if c == java.lang.Short.TYPE => Some("toShortArray") | ||
| case c if c == java.lang.Integer.TYPE => Some("toIntArray") | ||
| case c if c == java.lang.Long.TYPE => Some("toLongArray") | ||
| case c if c == java.lang.Float.TYPE => Some("toFloatArray") | ||
| case c if c == java.lang.Double.TYPE => Some("toDoubleArray") | ||
| case _ => None | ||
| } | ||
|
|
||
| primitiveMethod.map { method => | ||
| Invoke(getPath, method, ObjectType(c)) | ||
| }.getOrElse { | ||
| Invoke( | ||
| MapObjects( | ||
| p => constructorFor(typeToken.getComponentType, Some(p)), | ||
| getPath, | ||
| inferDataType(elementType)._1), | ||
| "array", | ||
| ObjectType(c)) | ||
| } | ||
|
|
||
| case c if listType.isAssignableFrom(typeToken) => | ||
| val et = elementType(typeToken) | ||
| val array = | ||
| Invoke( | ||
| MapObjects( | ||
| p => constructorFor(et, Some(p)), | ||
| getPath, | ||
| inferDataType(et)._1), | ||
| "array", | ||
| ObjectType(classOf[Array[Any]])) | ||
|
|
||
| StaticInvoke(classOf[java.util.Arrays], ObjectType(c), "asList", array :: Nil) | ||
|
|
||
| case _ if mapType.isAssignableFrom(typeToken) => | ||
| val (keyType, valueType) = mapKeyValueType(typeToken) | ||
| val keyDataType = inferDataType(keyType)._1 | ||
| val valueDataType = inferDataType(valueType)._1 | ||
|
|
||
| val keyData = | ||
| Invoke( | ||
| MapObjects( | ||
| p => constructorFor(keyType, Some(p)), | ||
| Invoke(getPath, "keyArray", ArrayType(keyDataType)), | ||
| keyDataType), | ||
| "array", | ||
| ObjectType(classOf[Array[Any]])) | ||
|
|
||
| val valueData = | ||
| Invoke( | ||
| MapObjects( | ||
| p => constructorFor(valueType, Some(p)), | ||
| Invoke(getPath, "valueArray", ArrayType(valueDataType)), | ||
| valueDataType), | ||
| "array", | ||
| ObjectType(classOf[Array[Any]])) | ||
|
|
||
| StaticInvoke( | ||
| ArrayBasedMapData, | ||
| ObjectType(classOf[JMap[_, _]]), | ||
| "toJavaMap", | ||
| keyData :: valueData :: Nil) | ||
|
|
||
| case other => | ||
| val properties = getJavaBeanProperties(other) | ||
| assert(properties.length > 0) | ||
|
|
||
| val setters = properties.map { p => | ||
| val fieldName = p.getName | ||
| val fieldType = typeToken.method(p.getReadMethod).getReturnType | ||
| p.getWriteMethod.getName -> constructorFor(fieldType, Some(addToPath(fieldName))) | ||
| }.toMap | ||
|
|
||
| val newInstance = NewInstance(other, Nil, propagateNull = false, ObjectType(other)) | ||
| val result = InitializeJavaBean(newInstance, setters) | ||
|
|
||
| if (path.nonEmpty) { | ||
| expressions.If( | ||
| IsNull(getPath), | ||
| expressions.Literal.create(null, ObjectType(other)), | ||
| result | ||
| ) | ||
| } else { | ||
| result | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Returns expressions for extracting all the fields from the given type. | ||
| */ | ||
| def extractorsFor(beanClass: Class[_]): CreateNamedStruct = { | ||
| val inputObject = BoundReference(0, ObjectType(beanClass), nullable = true) | ||
| extractorFor(inputObject, TypeToken.of(beanClass)).asInstanceOf[CreateNamedStruct] | ||
| } | ||
|
|
||
| private def extractorFor(inputObject: Expression, typeToken: TypeToken[_]): Expression = { | ||
|
|
||
| def toCatalystArray(input: Expression, elementType: TypeToken[_]): Expression = { | ||
| val (dataType, nullable) = inferDataType(elementType) | ||
| if (ScalaReflection.isNativeType(dataType)) { | ||
| NewInstance( | ||
| classOf[GenericArrayData], | ||
| input :: Nil, | ||
| dataType = ArrayType(dataType, nullable)) | ||
| } else { | ||
| MapObjects(extractorFor(_, elementType), input, ObjectType(elementType.getRawType)) | ||
| } | ||
| } | ||
|
|
||
| if (!inputObject.dataType.isInstanceOf[ObjectType]) { | ||
| inputObject | ||
| } else { | ||
| typeToken.getRawType match { | ||
| case c if c == classOf[String] => | ||
| StaticInvoke( | ||
| classOf[UTF8String], | ||
| StringType, | ||
| "fromString", | ||
| inputObject :: Nil) | ||
|
|
||
| case c if c == classOf[java.sql.Timestamp] => | ||
| StaticInvoke( | ||
| DateTimeUtils, | ||
| TimestampType, | ||
| "fromJavaTimestamp", | ||
| inputObject :: Nil) | ||
|
|
||
| case c if c == classOf[java.sql.Date] => | ||
| StaticInvoke( | ||
| DateTimeUtils, | ||
| DateType, | ||
| "fromJavaDate", | ||
| inputObject :: Nil) | ||
|
|
||
| case c if c == classOf[java.math.BigDecimal] => | ||
| StaticInvoke( | ||
| Decimal, | ||
| DecimalType.SYSTEM_DEFAULT, | ||
| "apply", | ||
| inputObject :: Nil) | ||
|
|
||
| case c if c == classOf[java.lang.Boolean] => | ||
| Invoke(inputObject, "booleanValue", BooleanType) | ||
| case c if c == classOf[java.lang.Byte] => | ||
| Invoke(inputObject, "byteValue", ByteType) | ||
| case c if c == classOf[java.lang.Short] => | ||
| Invoke(inputObject, "shortValue", ShortType) | ||
| case c if c == classOf[java.lang.Integer] => | ||
| Invoke(inputObject, "intValue", IntegerType) | ||
| case c if c == classOf[java.lang.Long] => | ||
| Invoke(inputObject, "longValue", LongType) | ||
| case c if c == classOf[java.lang.Float] => | ||
| Invoke(inputObject, "floatValue", FloatType) | ||
| case c if c == classOf[java.lang.Double] => | ||
| Invoke(inputObject, "doubleValue", DoubleType) | ||
|
|
||
| case _ if typeToken.isArray => | ||
| toCatalystArray(inputObject, typeToken.getComponentType) | ||
|
|
||
| case _ if listType.isAssignableFrom(typeToken) => | ||
| toCatalystArray(inputObject, elementType(typeToken)) | ||
|
|
||
| case _ if mapType.isAssignableFrom(typeToken) => | ||
| // TODO: for java map, if we get the keys and values by `keySet` and `values`, we can | ||
| // not guarantee they have same iteration order(which is different from scala map). | ||
| // A possible solution is creating a new `MapObjects` that can iterate a map directly. | ||
| throw new UnsupportedOperationException("map type is not supported currently") | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The problem is that, for java map, if we get the keys and values by cc @marmbrus |
||
|
|
||
| case other => | ||
| val properties = getJavaBeanProperties(other) | ||
| if (properties.length > 0) { | ||
| CreateNamedStruct(properties.flatMap { p => | ||
| val fieldName = p.getName | ||
| val fieldType = typeToken.method(p.getReadMethod).getReturnType | ||
| val fieldValue = Invoke( | ||
| inputObject, | ||
| p.getReadMethod.getName, | ||
| inferExternalType(fieldType.getRawType)) | ||
| expressions.Literal(fieldName) :: extractorFor(fieldValue, fieldType) :: Nil | ||
| }) | ||
| } else { | ||
| throw new UnsupportedOperationException(s"no encoder found for ${other.getName}") | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some documentation about what is supported and what is not here?