-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-10521][SQL] Utilize Docker for test DB2 JDBC Dialect support #9893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1e3fcfe
[SPARK-10521][SQL] Utilize Docker for test DB2 JDBS Dialect support
lresende 9795752
[SPARK-10521] Update valid DB2 data types in test
lresende a7bade9
[SPARK-10521] Add required parameters to start DB2 Docker Image
lresende 95e15bf
[SPARK-10521] Add DB2 dependencies to pom.xml
lresende 844efd2
[SPARK-10521] Change password for db2inst user
lresende b5993f1
[SPARK-10521] Enable optional startup process configuration
lresende 8d9ee23
[SPARK-10521] Update DB2 docker image used for test
lresende a8837bb
[SPARK-10521] Fix scala style issues
lresende 2452aa3
[SPARK-10521] Add DB2 repository
lresende ac3a2ee
[SPARK-10521] Update OracleIntegrationSuite with startup process name
lresende 70ded1e
[SPARK-10521] Refactor DB2 docker based tests to new project location
lresende b9bf635
[SPARK-10521] Utilize ipcMode to avoid shared memory issues with DB2
lresende 9c87286
[SPARK-10521] Ignore test due to unsupported kernel version in build …
lresende 31e1d8b
[SPARK-10521] Fix scala style issue
lresende File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
157 changes: 157 additions & 0 deletions
157
...cker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DB2IntegrationSuite.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.jdbc | ||
|
|
||
| import java.math.BigDecimal | ||
| import java.sql.{Connection, Date, Timestamp} | ||
| import java.util.Properties | ||
|
|
||
| import org.scalatest._ | ||
|
|
||
| import org.apache.spark.tags.DockerTest | ||
|
|
||
| @DockerTest | ||
| @Ignore // AMPLab Jenkins needs to be updated before shared memory works on docker | ||
| class DB2IntegrationSuite extends DockerJDBCIntegrationSuite { | ||
| override val db = new DatabaseOnDocker { | ||
| override val imageName = "lresende/db2express-c:10.5.0.5-3.10.0" | ||
| override val env = Map( | ||
| "DB2INST1_PASSWORD" -> "rootpass", | ||
| "LICENSE" -> "accept" | ||
| ) | ||
| override val usesIpc = true | ||
| override val jdbcPort: Int = 50000 | ||
| override def getJdbcUrl(ip: String, port: Int): String = | ||
| s"jdbc:db2://$ip:$port/foo:user=db2inst1;password=rootpass;" | ||
| override def getStartupProcessName: Option[String] = Some("db2start") | ||
| } | ||
|
|
||
| override def dataPreparation(conn: Connection): Unit = { | ||
| conn.prepareStatement("CREATE TABLE tbl (x INTEGER, y VARCHAR(8))").executeUpdate() | ||
| conn.prepareStatement("INSERT INTO tbl VALUES (42,'fred')").executeUpdate() | ||
| conn.prepareStatement("INSERT INTO tbl VALUES (17,'dave')").executeUpdate() | ||
|
|
||
| conn.prepareStatement("CREATE TABLE numbers (onebit BIT(1), tenbits BIT(10), " | ||
| + "small SMALLINT, med MEDIUMINT, nor INT, big BIGINT, deci DECIMAL(40,20), flt FLOAT, " | ||
| + "dbl DOUBLE)").executeUpdate() | ||
| conn.prepareStatement("INSERT INTO numbers VALUES (b'0', b'1000100101', " | ||
| + "17, 77777, 123456789, 123456789012345, 123456789012345.123456789012345, " | ||
| + "42.75, 1.0000000000000002)").executeUpdate() | ||
|
|
||
| conn.prepareStatement("CREATE TABLE dates (d DATE, t TIME, dt DATETIME, ts TIMESTAMP, " | ||
| + "yr YEAR)").executeUpdate() | ||
| conn.prepareStatement("INSERT INTO dates VALUES ('1991-11-09', '13:31:24', " | ||
| + "'1996-01-01 01:23:45', '2009-02-13 23:31:30', '2001')").executeUpdate() | ||
|
|
||
| // TODO: Test locale conversion for strings. | ||
| conn.prepareStatement("CREATE TABLE strings (a CHAR(10), b VARCHAR(10), c CLOB, d BLOB, " | ||
| + "e CHAR FOR BIT DATA)").executeUpdate() | ||
| conn.prepareStatement("INSERT INTO strings VALUES ('the', 'quick', 'brown', 'fox', 'jumps'") | ||
| .executeUpdate() | ||
| } | ||
|
|
||
| test("Basic test") { | ||
| val df = sqlContext.read.jdbc(jdbcUrl, "tbl", new Properties) | ||
| val rows = df.collect() | ||
| assert(rows.length == 2) | ||
| val types = rows(0).toSeq.map(x => x.getClass.toString) | ||
| assert(types.length == 2) | ||
| assert(types(0).equals("class java.lang.Integer")) | ||
| assert(types(1).equals("class java.lang.String")) | ||
| } | ||
|
|
||
| test("Numeric types") { | ||
| val df = sqlContext.read.jdbc(jdbcUrl, "numbers", new Properties) | ||
| val rows = df.collect() | ||
| assert(rows.length == 1) | ||
| val types = rows(0).toSeq.map(x => x.getClass.toString) | ||
| assert(types.length == 9) | ||
| assert(types(0).equals("class java.lang.Boolean")) | ||
| assert(types(1).equals("class java.lang.Long")) | ||
| assert(types(2).equals("class java.lang.Integer")) | ||
| assert(types(3).equals("class java.lang.Integer")) | ||
| assert(types(4).equals("class java.lang.Integer")) | ||
| assert(types(5).equals("class java.lang.Long")) | ||
| assert(types(6).equals("class java.math.BigDecimal")) | ||
| assert(types(7).equals("class java.lang.Double")) | ||
| assert(types(8).equals("class java.lang.Double")) | ||
| assert(rows(0).getBoolean(0) == false) | ||
| assert(rows(0).getLong(1) == 0x225) | ||
| assert(rows(0).getInt(2) == 17) | ||
| assert(rows(0).getInt(3) == 77777) | ||
| assert(rows(0).getInt(4) == 123456789) | ||
| assert(rows(0).getLong(5) == 123456789012345L) | ||
| val bd = new BigDecimal("123456789012345.12345678901234500000") | ||
| assert(rows(0).getAs[BigDecimal](6).equals(bd)) | ||
| assert(rows(0).getDouble(7) == 42.75) | ||
| assert(rows(0).getDouble(8) == 1.0000000000000002) | ||
| } | ||
|
|
||
| test("Date types") { | ||
| val df = sqlContext.read.jdbc(jdbcUrl, "dates", new Properties) | ||
| val rows = df.collect() | ||
| assert(rows.length == 1) | ||
| val types = rows(0).toSeq.map(x => x.getClass.toString) | ||
| assert(types.length == 5) | ||
| assert(types(0).equals("class java.sql.Date")) | ||
| assert(types(1).equals("class java.sql.Timestamp")) | ||
| assert(types(2).equals("class java.sql.Timestamp")) | ||
| assert(types(3).equals("class java.sql.Timestamp")) | ||
| assert(types(4).equals("class java.sql.Date")) | ||
| assert(rows(0).getAs[Date](0).equals(Date.valueOf("1991-11-09"))) | ||
| assert(rows(0).getAs[Timestamp](1).equals(Timestamp.valueOf("1970-01-01 13:31:24"))) | ||
| assert(rows(0).getAs[Timestamp](2).equals(Timestamp.valueOf("1996-01-01 01:23:45"))) | ||
| assert(rows(0).getAs[Timestamp](3).equals(Timestamp.valueOf("2009-02-13 23:31:30"))) | ||
| assert(rows(0).getAs[Date](4).equals(Date.valueOf("2001-01-01"))) | ||
| } | ||
|
|
||
| test("String types") { | ||
| val df = sqlContext.read.jdbc(jdbcUrl, "strings", new Properties) | ||
| val rows = df.collect() | ||
| assert(rows.length == 1) | ||
| val types = rows(0).toSeq.map(x => x.getClass.toString) | ||
| assert(types.length == 9) | ||
| assert(types(0).equals("class java.lang.String")) | ||
| assert(types(1).equals("class java.lang.String")) | ||
| assert(types(2).equals("class java.lang.String")) | ||
| assert(types(3).equals("class java.lang.String")) | ||
| assert(types(4).equals("class java.lang.String")) | ||
| assert(types(5).equals("class java.lang.String")) | ||
| assert(types(6).equals("class [B")) | ||
| assert(types(7).equals("class [B")) | ||
| assert(types(8).equals("class [B")) | ||
| assert(rows(0).getString(0).equals("the")) | ||
| assert(rows(0).getString(1).equals("quick")) | ||
| assert(rows(0).getString(2).equals("brown")) | ||
| assert(rows(0).getString(3).equals("fox")) | ||
| assert(rows(0).getString(4).equals("jumps")) | ||
| assert(rows(0).getString(5).equals("over")) | ||
| assert(java.util.Arrays.equals(rows(0).getAs[Array[Byte]](6), Array[Byte](116, 104, 101, 0))) | ||
| assert(java.util.Arrays.equals(rows(0).getAs[Array[Byte]](7), Array[Byte](108, 97, 122, 121))) | ||
| assert(java.util.Arrays.equals(rows(0).getAs[Array[Byte]](8), Array[Byte](100, 111, 103))) | ||
| } | ||
|
|
||
| test("Basic write test") { | ||
| val df1 = sqlContext.read.jdbc(jdbcUrl, "numbers", new Properties) | ||
| val df2 = sqlContext.read.jdbc(jdbcUrl, "dates", new Properties) | ||
| val df3 = sqlContext.read.jdbc(jdbcUrl, "strings", new Properties) | ||
| df1.write.jdbc(jdbcUrl, "numberscopy", new Properties) | ||
| df2.write.jdbc(jdbcUrl, "datescopy", new Properties) | ||
| df3.write.jdbc(jdbcUrl, "stringscopy", new Properties) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine but I'll be really mad if this repository ever goes down and breaks the build 😄