Skip to content

[SPARK-11771][YARN][TRIVIAL] maximum memory in yarn is controlled by two params have both in error msg #9758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
holdenk wants to merge 4 commits into from
Closed

[SPARK-11771][YARN][TRIVIAL] maximum memory in yarn is controlled by two params have both in error msg #9758

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f31998
Add yarn.nodemanager.resource.memory-mb to the error message when exc…
holdenk Nov 17, 2015
4e530a1
fix punctation
holdenk Nov 17, 2015
5e38c39
s/and/and\/or/
holdenk Nov 17, 2015
9125fcf
say check the values instead
holdenk Nov 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,8 @@ private[spark] class Client(
if (executorMem > maxMem) {
throw new IllegalArgumentException(s"Required executor memory (${args.executorMemory}" +
s"+$executorMemoryOverhead MB) is above the max threshold ($maxMem MB) of this cluster! " +
"Please increase the value of 'yarn.scheduler.maximum-allocation-mb'.")
"Please increase the value of 'yarn.scheduler.maximum-allocation-mb' and" +
Copy link
Member

@srowen srowen Nov 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"and/or"? it could really be due to either one -- the max the scheduler will schedule, or the limit on the max size of a container. It may not need an increase in both.

Copy link
Contributor

@tgravescs tgravescs Nov 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, it would definitely and/or.. but I kind of question why we need this at all? The scheduler max is really what its compared to. If your nodemanagers aren't configured to have enough memory to meet that then I would say you have misconfigured your cluster. I'm fine with leaving the error in there if people fine is useful but I agree with @srowen I think this should be reworded to say something like check the values of ... rather then please increase the values.

Copy link
Contributor Author

@holdenk holdenk Nov 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've switched it to and/or + check the values. I think its a useful error for people trying to run Spark on YARN who might not know what the configuration params are they need here (much better than the alternative of dumping a stack trace to nowhere in particular).

"'yarn.nodemanager.resource.memory-mb'.")
}
val amMem = args.amMemory + amMemoryOverhead
if (amMem > maxMem) {
Expand Down