[Minor][SQL] Fix randomly generated ArrayData in RowEncoderSuite#9757
Closed
viirya wants to merge 1 commit intoapache:masterfrom
Closed
[Minor][SQL] Fix randomly generated ArrayData in RowEncoderSuite#9757viirya wants to merge 1 commit intoapache:masterfrom
viirya wants to merge 1 commit intoapache:masterfrom
Conversation
…nually generate it.
Member
Author
|
cc @davies |
Contributor
There was a problem hiding this comment.
Should we use the first element at least? Did we check the result in tests?
Member
Author
There was a problem hiding this comment.
We did check the results as we check input row and the row converted back.
Because this UDT ExamplePoint needs at least two double values. If the array generated by the random generator at the first contains only 1 or 0 elements. values.getDouble will throw out of range exception.
|
Test build #46051 has finished for PR 9757 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Nov 17, 2015
The randomly generated ArrayData used for the UDT `ExamplePoint` in `RowEncoderSuite` sometimes doesn't have enough elements. In this case, this test will fail. This patch is to fix it. Author: Liang-Chi Hsieh <viirya@appier.com> Closes #9757 from viirya/fix-randomgenerated-udt. (cherry picked from commit d79d8b0) Signed-off-by: Davies Liu <davies.liu@gmail.com>
Contributor
|
Merged into master and 1.6 branch, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The randomly generated ArrayData used for the UDT
ExamplePointinRowEncoderSuitesometimes doesn't have enough elements. In this case, this test will fail. This patch is to fix it.