Skip to content

[SPARK-10946][SQL]JDBC - Use Statement.executeUpdate instead of PreparedStatement.executeUpdate for DDLs #9733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
somideshmukh wants to merge 2 commits into from
Closed

[SPARK-10946][SQL]JDBC - Use Statement.executeUpdate instead of PreparedStatement.executeUpdate for DDLs #9733

somideshmukh wants to merge 2 commits into from
+2 −2

Conversation

@somideshmukh
Copy link
Contributor

@somideshmukh somideshmukh commented Nov 16, 2015

New changes with JDBCRDD

@srowen
Copy link
Member

srowen commented Nov 16, 2015

I agree with this, and am OK to merge this.
There is still an issue with not closing the Statements, although it's a separate issue.

@SparkQA
Copy link

SparkQA commented Nov 16, 2015

Test build #2063 has finished for PR 9733 at commit 9db069d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

srowen
srowen reviewed Nov 17, 2015
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala Outdated
Copy link
Member

@srowen srowen Nov 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah hang on a sec, I see you've changed some non-DDL statements in this version of the PR. The change is just about avoiding PreparedStatement for DDL right? My earlier comments were about closing resources for a bunch of queries including non-DDL. But if you're only addressing DDL, then your last PR was fine (before it was corrupted).

@somideshmukh
Copy link
Contributor Author

somideshmukh commented Nov 17, 2015

OK,I will remove non-DDL statements and create new pull request.

@srowen
Copy link
Member

srowen commented Nov 17, 2015

You don't need a new PR, just push a new commit here. It's better, as it preserves the history of the discussion.

@somideshmukh
Copy link
Contributor Author

somideshmukh commented Nov 18, 2015

I have push new commit to SomilBranch-1.1

@asfgit asfgit closed this in b8f4379 Nov 18, 2015
asfgit pushed a commit that referenced this pull request Nov 18, 2015
@somideshmukh @srowen
[SPARK-10946][SQL] JDBC - Use Statement.executeUpdate instead of Prep…
5da7d41 
…aredStatement.executeUpdate for DDLs

New changes with JDBCRDD

Author: somideshmukh <[email protected]>

Closes #9733 from somideshmukh/SomilBranch-1.1.

(cherry picked from commit b8f4379)
Signed-off-by: Sean Owen <[email protected]>
@srowen
Copy link
Member

srowen commented Nov 18, 2015

Merged to master/1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@somideshmukh @srowen @SparkQA