Skip to content

[SPARK-11689] [ML] Add user guide and example code for LDA under spark.ml#9722

Closed
hhbyyh wants to merge 7 commits intoapache:masterfrom
hhbyyh:ldaMLExample
Closed

[SPARK-11689] [ML] Add user guide and example code for LDA under spark.ml#9722
hhbyyh wants to merge 7 commits intoapache:masterfrom
hhbyyh:ldaMLExample

Conversation

@hhbyyh
Copy link
Contributor

@hhbyyh hhbyyh commented Nov 15, 2015

jira: https://issues.apache.org/jira/browse/SPARK-11689

Add simple user guide for LDA under spark.ml and example code under examples/. Use include_example to include example code in the user guide markdown. Check SPARK-11606 for instructions.

@SparkQA
Copy link

SparkQA commented Nov 15, 2015

Test build #45951 has finished for PR 9722 at commit 8a6d2d6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaLDAExample\n

@SparkQA
Copy link

SparkQA commented Nov 17, 2015

Test build #46061 has finished for PR 9722 at commit 195c85c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaLDAExample\n

@mengxr
Copy link
Contributor

mengxr commented Nov 17, 2015

cc: @feynmanliang

docs/ml-guide.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other links in this section are sorted alphabetically

@feynmanliang
Copy link
Contributor

Made a pass

@SparkQA
Copy link

SparkQA commented Nov 19, 2015

Test build #46336 has finished for PR 9722 at commit 5e22624.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaLDAExample\n

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was supposed to read "In this section, we introduce the pipeline API for clustering in mllib"? The pipelines API doesn't "correspond" to mllib since it's missing a lot of features

@feynmanliang
Copy link
Contributor

LGTM after changes

@hhbyyh
Copy link
Contributor Author

hhbyyh commented Nov 20, 2015

ERROR: Timeout after 15 minutes
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from https://github.com/apache/spark.git

@feynmanliang
Copy link
Contributor

LGTM

@feynmanliang
Copy link
Contributor

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Nov 20, 2015

Test build #46408 has finished for PR 9722 at commit c794096.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaLDAExample\n

asfgit pushed a commit that referenced this pull request Nov 20, 2015
jira: https://issues.apache.org/jira/browse/SPARK-11689

Add simple user guide for LDA under spark.ml and example code under examples/. Use include_example to include example code in the user guide markdown. Check SPARK-11606 for instructions.

Author: Yuhao Yang <hhbyyh@gmail.com>

Closes #9722 from hhbyyh/ldaMLExample.

(cherry picked from commit e359d5d)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@mengxr
Copy link
Contributor

mengxr commented Nov 20, 2015

Merged into master and branch-1.6. Thanks!

@asfgit asfgit closed this in e359d5d Nov 20, 2015
@mengxr
Copy link
Contributor

mengxr commented Nov 21, 2015

@hhbyyh I reverted the commit because it failed doc build. Could you re-open this PR and try SKIP_API=1 jekyll build on your local. I thought this is tested in PR build but actually not. Sorry!

@hhbyyh
Copy link
Contributor Author

hhbyyh commented Nov 21, 2015

I'll look into it immediately. Sorry for the troubling.
This takes longer than I thought, as I'm still struggling to config my local environment for document build via all kinds of proxies, thanks to Chinese network....

@yinxusen
Copy link
Contributor

@hhbyyh The Java example is lack of // $example on$ and // $example off$.

@yinxusen
Copy link
Contributor

@mengxr It's really a problem of testing example code and markdown doc in the test time. I think Spark QA cannot grasp this kind of errors.

@hhbyyh
Copy link
Contributor Author

hhbyyh commented Nov 25, 2015

@yinxusen Thanks a lot. It seems I cannot reopen the PR. I'll create a new one.

Yet I keep getting error compiling QueryExecutionListener.scala during build/sbt unidoc. Have you met a similar issue?

@yinxusen
Copy link
Contributor

@hhbyyh I am not familiar with sbt unidoc, but since it is an example file, there is no need to generate API docs and check them. You can use SKIP_API=1 jekyll serve --watch to avoid generating API docs.

@hhbyyh
Copy link
Contributor Author

hhbyyh commented Nov 25, 2015

Yes Thanks.

asfgit pushed a commit that referenced this pull request Nov 30, 2015
jira: https://issues.apache.org/jira/browse/SPARK-11689

Add simple user guide for LDA under spark.ml and example code under examples/. Use include_example to include example code in the user guide markdown. Check SPARK-11606 for instructions.

Original PR is reverted due to document build error. #9722

mengxr feynmanliang yinxusen  Sorry for the troubling.

Author: Yuhao Yang <hhbyyh@gmail.com>

Closes #9974 from hhbyyh/ldaMLExample.

(cherry picked from commit e232720)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
asfgit pushed a commit that referenced this pull request Nov 30, 2015
jira: https://issues.apache.org/jira/browse/SPARK-11689

Add simple user guide for LDA under spark.ml and example code under examples/. Use include_example to include example code in the user guide markdown. Check SPARK-11606 for instructions.

Original PR is reverted due to document build error. #9722

mengxr feynmanliang yinxusen  Sorry for the troubling.

Author: Yuhao Yang <hhbyyh@gmail.com>

Closes #9974 from hhbyyh/ldaMLExample.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants