[SPARK-11643] [SQL] parse year with leading zero #9701
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #45886 has finished for PR 9701 at commit
|
|
Test build #2062 has finished for PR 9701 at commit
|
Contributor
There was a problem hiding this comment.
if s is not empty, we will never get into this branch right?
To handle empty s, I think a better idea is changing the default value of segments to [-1, -1, -1]
Contributor
Author
There was a problem hiding this comment.
No, if s is 123, then i = 0, j = 3
Contributor
|
LGTM except a minor suggestion |
asfgit
pushed a commit
that referenced
this pull request
Nov 18, 2015
Support the years between 0 <= year < 1000 Author: Davies Liu <[email protected]> Closes #9701 from davies/leading_zero. (cherry picked from commit 2f191c6) Signed-off-by: Davies Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the years between 0 <= year < 1000