-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-11612] [ML] Pipeline and PipelineModel persistence #9674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #45764 has finished for PR 9674 at commit
|
3700091 to
caf57c2
Compare
|
test this please |
|
Test build #45897 has finished for PR 9674 at commit
|
|
test this please |
|
Test build #46012 has finished for PR 9674 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should users be able to save an incomplete pipeline? For example, I could make a template pipeline, send it to other users, and they only need to fill in some required params like inputCol after they load it back.
|
One suggestion is to merge |
…ipelineModel, to clean up namespace
|
@mengxr Thanks for reviewing! I believe I addressed everything, except where I quibbled in responses above. |
|
LGTM pending Jenkins. |
|
Test build #46026 has finished for PR 9674 at commit
|
|
@mengxr Thank you for reviewing! Merging with master and branch-1.6 |
Pipeline and PipelineModel extend Readable and Writable. Persistence succeeds only when all stages are Writable. Note: This PR reinstates tests for other read/write functionality. It should probably not get merged until [https://issues.apache.org/jira/browse/SPARK-11672] gets fixed. CC: mengxr Author: Joseph K. Bradley <[email protected]> Closes #9674 from jkbradley/pipeline-io. (cherry picked from commit 1c5475f) Signed-off-by: Joseph K. Bradley <[email protected]>
Pipeline and PipelineModel extend Readable and Writable. Persistence succeeds only when all stages are Writable.
Note: This PR reinstates tests for other read/write functionality. It should probably not get merged until [https://issues.apache.org/jira/browse/SPARK-11672] gets fixed.
CC: @mengxr