[SPARK-11626][ML]ml.feature.Word2Vec.transform() function very slow #9592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… broadcast every sentence
|
Test build #2029 has finished for PR 9592 at commit
|
Contributor
|
@979969786 Could you try marking |
Member
Author
|
OK, marking wordVectors @transient is better than don't marking, but still very slow |
Contributor
|
@979969786 I sent you a PR at https://github.com/979969786/spark/pull/1. I think it should fix the problem (though I didn't test). |
fix serialization issues in ml.Word2Vec
Member
Author
|
I 've tested, running correctly and quickly. |
Contributor
|
ok to test |
Contributor
|
test this please |
|
Test build #45644 has finished for PR 9592 at commit
|
Contributor
|
Merged into master and branch-1.6. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Nov 11, 2015
org.apache.spark.ml.feature.Word2Vec.transform() very slow. we should not read broadcast every sentence. Author: Yuming Wang <[email protected]> Author: yuming.wang <[email protected]> Author: Xiangrui Meng <[email protected]> Closes #9592 from 979969786/master. (cherry picked from commit 27524a3) Signed-off-by: Xiangrui Meng <[email protected]>
dskrvk
pushed a commit
to dskrvk/spark
that referenced
this pull request
Nov 13, 2015
org.apache.spark.ml.feature.Word2Vec.transform() very slow. we should not read broadcast every sentence. Author: Yuming Wang <[email protected]> Author: yuming.wang <[email protected]> Author: Xiangrui Meng <[email protected]> Closes apache#9592 from 979969786/master.
Contributor
|
cc @yinxusen for the performance issue and the fix. |
Contributor
|
Got it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.apache.spark.ml.feature.Word2Vec.transform() very slow. we should not read broadcast every sentence.