-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-11482][SQL] Make maven repo for Hive metastore jars configurable #9543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think it can be used for who have their custom hive hosted on their own maven repository. Though using maven to download hive metastore jars is using for test, I still think this is a nice feature. |
|
Thanks WangTao for your comment! Based on the comment on my other PR for Spark-11562, I will also add documentation for this. |
|
I think this is fine to add. |
|
Jenkins, test this please. |
|
@rxin Thanks, Reynold! Somehow no test was triggered. Not sure why. |
|
Test build #2095 has finished for PR 9543 at commit
|
|
@rxin Sorry about the failure, can we re-test please? |
|
Test build #2100 has finished for PR 9543 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either put each on one line, or don't wrap them at all here.
[SPARK-11482][SQL] documentation for configurable maven repo Fix Scalastyle check failure Correct code format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use HIVE_METASTORE_MAVEN_REPO's default value at here? So, in case we update that default value, this one will be updated as well.
|
@xguo27 Can I ask what is your specific use case for this? |
|
Thanks @yhuai for reviewing my code! I have updated per your suggestion. To answer your question, I personally do not have a use case for this. My take on the JIRA reporter's use case is that user might host their own customized/modified Hive jars on their maven site which might provide specific functionality. |
|
Can one of the admins verify this patch? |
|
I'm going to close this one for now. |
Closes apache#14537. Closes apache#16181. Closes apache#8318. Closes apache#6848. Closes apache#7265. Closes apache#9543.
Introducing a property called "spark.sql.hive.maven.repo" to let user configure the maven repository to download Hive Metastore jars.