Skip to content

Conversation

@xguo27
Copy link
Contributor

@xguo27 xguo27 commented Nov 8, 2015

Introducing a property called "spark.sql.hive.maven.repo" to let user configure the maven repository to download Hive Metastore jars.

@WangTaoTheTonic
Copy link
Contributor

I think it can be used for who have their custom hive hosted on their own maven repository.

Though using maven to download hive metastore jars is using for test, I still think this is a nice feature.

@xguo27
Copy link
Contributor Author

xguo27 commented Nov 9, 2015

Thanks WangTao for your comment!

Based on the comment on my other PR for Spark-11562, I will also add documentation for this.

@xguo27
Copy link
Contributor Author

xguo27 commented Nov 20, 2015

@marmbrus @rxin What do you think about this change?

@rxin
Copy link
Contributor

rxin commented Nov 20, 2015

I think this is fine to add.

@rxin
Copy link
Contributor

rxin commented Nov 20, 2015

Jenkins, test this please.

@xguo27
Copy link
Contributor Author

xguo27 commented Nov 21, 2015

@rxin Thanks, Reynold! Somehow no test was triggered. Not sure why.

@SparkQA
Copy link

SparkQA commented Nov 21, 2015

Test build #2095 has finished for PR 9543 at commit 92cb677.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@xguo27
Copy link
Contributor Author

xguo27 commented Nov 22, 2015

@rxin Sorry about the failure, can we re-test please?

@SparkQA
Copy link

SparkQA commented Nov 24, 2015

Test build #2100 has finished for PR 9543 at commit f109baf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either put each on one line, or don't wrap them at all here.

[SPARK-11482][SQL] documentation for configurable maven repo

Fix Scalastyle check failure

Correct code format
@xguo27
Copy link
Contributor Author

xguo27 commented Nov 28, 2015

@yhuai I see your latest delivery has conflict with this PR, I have resolved the conflict and re-pushed. @rxin has been reviewing this PR, I figure you might also want to review this PR, just in case I break your code.

Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use HIVE_METASTORE_MAVEN_REPO's default value at here? So, in case we update that default value, this one will be updated as well.

@yhuai
Copy link
Contributor

yhuai commented Nov 29, 2015

@xguo27 Can I ask what is your specific use case for this?

@xguo27
Copy link
Contributor Author

xguo27 commented Nov 29, 2015

Thanks @yhuai for reviewing my code! I have updated per your suggestion.

To answer your question, I personally do not have a use case for this. My take on the JIRA reporter's use case is that user might host their own customized/modified Hive jars on their maven site which might provide specific functionality.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@rxin
Copy link
Contributor

rxin commented Dec 7, 2016

I'm going to close this one for now.

@asfgit asfgit closed this in 08d6441 Dec 7, 2016
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants