Skip to content

[SPARK-11433] [SQL] Cleanup the subquery name after eliminating subquery #9385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gatorsmile wants to merge 2 commits into from
Closed

[SPARK-11433] [SQL] Cleanup the subquery name after eliminating subquery #9385

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db69ccf
cleanup the subquery name after eliminating subquery
Oct 30, 2015
a26763d
flatmap->map
gatorsmile Nov 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,7 +1019,16 @@ class Analyzer(
* scoping information for attributes and can be removed once analysis is complete.
*/
object EliminateSubQueries extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan transform {
def apply(plan: LogicalPlan): LogicalPlan = plan transformDown {

@holdenk holdenk Nov 2, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for switching to transformDown?

@gatorsmile gatorsmile Nov 3, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comments! If we doing transformUp, subquery will be removed at first. Then, Project(projectList, child: Subquery) will not be applicable in this case.

case Project(projectList, child: Subquery) => {
Project(
projectList.flatMap {

@holdenk holdenk Nov 2, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we simplify this to a map and remove the :: Nil we have in the two sub cases? since it seems we are always returning a single element list for every case so it should be ok as a map.

@gatorsmile gatorsmile Nov 4, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I did the change based on your suggestion. : )

case ar: AttributeReference if ar.qualifiers.contains(child.alias) =>

@gatorsmile gatorsmile Oct 30, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I use NamedExpression to replace AttributeReference?

ar.withQualifiers(ar.qualifiers.filter(_!=child.alias)) :: Nil
case o => o :: Nil
},
child)
}
case Subquery(_, child) => child
}
}
Expand Down