[SPARK-1995][SQL] system function upper and lower can be supported#936
[SPARK-1995][SQL] system function upper and lower can be supported#936egraldlo wants to merge 5 commits intoapache:masterfrom egraldlo:stringoperator
Conversation
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
converted seems better than beConverted here.
|
LGTM except some minor formatting issues. |
|
Thanks for doing this! We should add this to the hive parser as well. |
There was a problem hiding this comment.
Perhaps, "A function that converts the characters of a string to uppercase."
|
thanks @liancheng and @marmbrus, I have modified the formatting issues and "nullable". |
|
hi @liancheng, @marmbrus, in HiveQl.scala, MAX and MIN is not in it, maybe aggregation function max and min were supported afterwards. |
|
test this please |
|
Merged build triggered. |
|
Merged build started. |
|
Change the PR title to begin with [SPARK-1995][SQL] ... please |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
egraldlo
changed the title
|
Thanks for doing this! Merged in master and 1.0 |
I don't know whether it's time to implement system function about string operation in spark sql now. Author: egraldlo <egraldlo@gmail.com> Closes #936 from egraldlo/stringoperator and squashes the following commits: 3c6c60a [egraldlo] Add UPPER, LOWER, MAX and MIN into hive parser ea76d0a [egraldlo] modify the formatting issues b49f25e [egraldlo] modify the formatting issues 1f0bbb5 [egraldlo] system function upper and lower supported 13d3267 [egraldlo] system function upper and lower supported (cherry picked from commit ec8be27) Signed-off-by: Michael Armbrust <michael@databricks.com>
4 participants
I don't know whether it's time to implement system function about string operation in spark sql now.