Skip to content

[SPARK-5966][WIP]<Spark-submit deploy-mode cluster is not compatible with master local> #9220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevinyu98 wants to merge 3 commits into from
Closed

[SPARK-5966][WIP]<Spark-submit deploy-mode cluster is not compatible with master local> #9220

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
396c66a
[SPARK-5966]<Spark-submit deploy-mode cluster is not compatible with …
kevinyu98 Oct 22, 2015
6bb1491
implement code review comments
kevinyu98 Oct 22, 2015
dc75828
implement code review comments
kevinyu98 Oct 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,11 @@ object SparkSubmit {
}
}

// SPARK-5966, check deployMode CLUSTER and master local
if (clusterManager == LOCAL && deployMode == CLUSTER) {
printErrorAndExit("Cluster deploy mode is not compatible with master \"local\"")
}
Copy link
Contributor

@andrewor14 andrewor14 Oct 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a place down there (L321) where we do checks like this. Please move it down there to be more consistent

Copy link
Contributor Author

@kevinyu98 kevinyu98 Oct 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Andrew: Thanks for pointing this out, I have made the code changes, run the test , and submit the pull request, can you help review?
Kevin


Copy link
Contributor

@andrewor14 andrewor14 Oct 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'm going to nix this blank line when I merge (no action required on your part)

// Update args.deployMode if it is null. It will be passed down as a Spark property later.
(args.deployMode, deployMode) match {
case (null, CLIENT) => args.deployMode = "client"
Expand Down