Skip to content

[SPARK-10799][Core]Fix InboxSuite 'post: multiple threads' #8905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zsxwing wants to merge 2 commits into from
Closed

[SPARK-10799][Core]Fix InboxSuite 'post: multiple threads' #8905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb59296
Fix InboxSuite 'post: multiple threads'
zsxwing Sep 24, 2015
95c3746
Remove unncessary comment
zsxwing Sep 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions core/src/main/scala/org/apache/spark/rpc/RpcEnv.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ private[spark] object RpcEnv {
// Add more RpcEnv implementations here
val rpcEnvNames = Map("akka" -> "org.apache.spark.rpc.akka.AkkaRpcEnvFactory",
"netty" -> "org.apache.spark.rpc.netty.NettyRpcEnvFactory")
// Use "netty" by default so that Jenkins can run all tests using NettyRpcEnv.
// Will change it back to "akka" before merging the new implementation.
val rpcEnvName = conf.get("spark.rpc", "netty")
val rpcEnvFactoryClassName = rpcEnvNames.getOrElse(rpcEnvName.toLowerCase, rpcEnvName)
Utils.classForName(rpcEnvFactoryClassName).newInstance().asInstanceOf[RpcEnvFactory]
Expand Down
4 changes: 3 additions & 1 deletion core/src/test/scala/org/apache/spark/rpc/netty/InboxSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,11 @@ class InboxSuite extends SparkFunSuite {
}
}.start()
}
// Try to process some messages
inbox.process(dispatcher)
assert(inbox.isEmpty)
inbox.stop()
// After `stop` is called, further messages will be dropped. However, while `stop` is called,
// some messages may be post to Inbox, so process them here.
inbox.process(dispatcher)
assert(inbox.isEmpty)

Expand Down