[SPARK-10543] [CORE] Peak Execution Memory Quantile should be Per-task Basis #8726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
add to whitelist |
Contributor
|
yeah, I think this is correct. Would you mind adding a unit test for it? If you prefer to do it separately we can also just merge this first. |
Contributor
Author
|
I added a naive unit test. Let me know if you think it's sufficient or clear. |
|
Test build #42364 has finished for PR 8726 at commit
|
|
Test build #42365 has finished for PR 8726 at commit
|
Contributor
|
Yup it looks good, thanks for fixing this I'm merging into master and 1.5. |
asfgit
pushed a commit
that referenced
this pull request
Sep 14, 2015
…k Basis
Read `PEAK_EXECUTION_MEMORY` using `update` to get per task partial value instead of cumulative value.
I tested with this workload:
```scala
val size = 1000
val repetitions = 10
val data = sc.parallelize(1 to size, 5).map(x => (util.Random.nextInt(size / repetitions),util.Random.nextDouble)).toDF("key", "value")
val res = data.toDF.groupBy("key").agg(sum("value")).count
```
Before:
After:
Tasks view:
cc andrewor14 I appreciate if you can give feedback on this since I think you introduced display of this metric.
Author: Forest Fang <[email protected]>
Closes #8726 from saurfang/stagepage.
(cherry picked from commit fd1e8cd)
Signed-off-by: Andrew Or <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read
PEAK_EXECUTION_MEMORYusingupdateto get per task partial value instead of cumulative value.I tested with this workload:
Before:
After:
Tasks view:
cc @andrewor14 I appreciate if you can give feedback on this since I think you introduced display of this metric.