[SPARK-10353] [MLLIB] (1.3 backport) BLAS gemm not scaling when beta = 0.0 for some subset of matrix multiplications #8572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #41931 has finished for PR 8572 at commit
|
|
Test FAILed. |
Member
Author
|
I think it actually passed, but not sure what to make of the conflicting messages from Jenkins here |
asfgit
pushed a commit
that referenced
this pull request
Sep 2, 2015
…= 0.0 for some subset of matrix multiplications Apply fixes for alpha, beta parameter handling in gemm/gemv from #8525 to branch 1.3 CC mengxr brkyvz Author: Sean Owen <[email protected]> Closes #8572 from srowen/SPARK-10353.2.
Contributor
|
LGTM and confirmed that Jenkins build passed. Merged into branch-1.3. Thanks! |
Contributor
|
Btw, please close this PR manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply fixes for alpha, beta parameter handling in gemm/gemv from #8525 to branch 1.3
CC @mengxr @brkyvz