Skip to content

[SPARK-10169] [SQL] [BRANCH-1.3] Partial aggregation's plan is wrong when a grouping expression is used as an argument of the aggregate fucntion #8380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yhuai wants to merge 2 commits into from
Closed

[SPARK-10169] [SQL] [BRANCH-1.3] Partial aggregation's plan is wrong when a grouping expression is used as an argument of the aggregate fucntion #8380

yhuai wants to merge 2 commits into from

Conversation

@yhuai
Copy link
Contributor

@yhuai yhuai commented Aug 23, 2015

@yhuai
Use transformDown.
f7f6945 
Conflicts:
	sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
@SparkQA
Copy link

SparkQA commented Aug 23, 2015

Test build #41419 has finished for PR 8380 at commit f7f6945.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 23, 2015

Test build #1681 has finished for PR 8380 at commit f7f6945.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan @yhuai
don't trim the top level Alias
059c956 
Conflicts:
	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
@SparkQA
Copy link

SparkQA commented Aug 24, 2015

Test build #41431 has finished for PR 8380 at commit 059c956.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 24, 2015

Test build #1682 has finished for PR 8380 at commit 059c956.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@marmbrus
Copy link
Contributor

marmbrus commented Aug 24, 2015

LGTM

asfgit pushed a commit that referenced this pull request Aug 24, 2015
@cloud-fan @marmbrus
[SPARK-10169] [SQL] [BRANCH-1.3] Partial aggregation's plan is wrong …
3d2eaf0 
…when a grouping expression is used as an argument of the aggregate fucntion

https://issues.apache.org/jira/browse/SPARK-10169

Author: Wenchen Fan <[email protected]>
Author: Yin Huai <[email protected]>

Closes #8380 from yhuai/aggTransformDown-branch1.3.
@marmbrus
Copy link
Contributor

marmbrus commented Aug 24, 2015

Thanks guys, merged!

@yhuai yhuai closed this Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yhuai @SparkQA @marmbrus @cloud-fan