Skip to content

Conversation

@MechCoder
Copy link
Contributor

No description provided.

@SparkQA
Copy link

SparkQA commented Aug 13, 2015

Test build #40779 has finished for PR 8171 at commit f1b7378.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Aug 13, 2015

Could you also fix the warning in core?

@MechCoder
Copy link
Contributor Author

Which warning is this? I do not get any warning

@SparkQA
Copy link

SparkQA commented Aug 13, 2015

Test build #40786 timed out for PR 8171 at commit 5f3ff18 after a configured wait of 175m.

@mengxr
Copy link
Contributor

mengxr commented Aug 13, 2015

I got the following:

/Users/meng/src/spark/python/pyspark/__init__.py:docstring of pyspark.SparkContext.applicationId:4: ERROR: Unexpected indentation.
/Users/meng/src/spark/python/pyspark/__init__.py:docstring of pyspark.SparkContext.applicationId:6: WARNING: Block quote ends without a blank line; unexpected unindent.

@MechCoder
Copy link
Contributor Author

I still could not reproduce the error. I just guessed it from the warning :P

@SparkQA
Copy link

SparkQA commented Aug 13, 2015

Test build #40812 has finished for PR 8171 at commit d21808c.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MechCoder
Copy link
Contributor Author

test this please

@SparkQA
Copy link

SparkQA commented Aug 14, 2015

Test build #40844 has finished for PR 8171 at commit d21808c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Aug 14, 2015

This is the generated html doc:

screen shot 2015-08-13 at 11 35 10 pm

I think we should use - with indentation instead of a] and b].

@MechCoder
Copy link
Contributor Author

I used asterisks as done in pyspark/mllib/clustering . Hopefully it should look good now.

@SparkQA
Copy link

SparkQA commented Aug 14, 2015

Test build #40851 has finished for PR 8171 at commit 239a8b9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Aug 20, 2015

LGTM. Merged into master and branch-1.5. Thanks!

@asfgit asfgit closed this in 52c6053 Aug 20, 2015
asfgit pushed a commit that referenced this pull request Aug 20, 2015
Author: MechCoder <[email protected]>

Closes #8171 from MechCoder/sql_sphinx.

(cherry picked from commit 52c6053)
Signed-off-by: Xiangrui Meng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants