[SPARK-9728][SQL]Support CalendarIntervalType in HiveQL#8034
[SPARK-9728][SQL]Support CalendarIntervalType in HiveQL#8034yjshen wants to merge 2 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
can you declare the possible exceptions here?
|
We should also add unit tests for CalendarInterval itself. |
|
It would also be good to actually fill out the description instead of just linking the JIRA, since this becomes the commit message. |
|
Test build #40175 has finished for PR 8034 at commit
|
|
Jenkins, retest this please. |
|
Test build #40215 timed out for PR 8034 at commit |
|
Test build #1413 has finished for PR 8034 at commit
|
|
Failure due to |
|
Test build #1412 has finished for PR 8034 at commit
|
|
Going to merge this. Thanks! |
This PR enables converting interval term in HiveQL to CalendarInterval Literal. JIRA: https://issues.apache.org/jira/browse/SPARK-9728 Author: Yijie Shen <henry.yijieshen@gmail.com> Closes #8034 from yjshen/interval_hiveql and squashes the following commits: 7fe9a5e [Yijie Shen] declare throw exception and add unit test fce7795 [Yijie Shen] convert hiveql interval term into CalendarInterval literal (cherry picked from commit 23695f1) Signed-off-by: Reynold Xin <rxin@databricks.com>
This PR enables converting interval term in HiveQL to CalendarInterval Literal. JIRA: https://issues.apache.org/jira/browse/SPARK-9728 Author: Yijie Shen <henry.yijieshen@gmail.com> Closes apache#8034 from yjshen/interval_hiveql and squashes the following commits: 7fe9a5e [Yijie Shen] declare throw exception and add unit test fce7795 [Yijie Shen] convert hiveql interval term into CalendarInterval literal
There was a problem hiding this comment.
Why not make unit Enum instead of String?
There was a problem hiding this comment.
This is good question. Strings spreads everywhere now. @cloud-fan How about introducing Scala enum (since the code has been moved to IntervalUtils) for interval units for now.
6 participants
This PR enables converting interval term in HiveQL to CalendarInterval Literal.
JIRA: https://issues.apache.org/jira/browse/SPARK-9728