[SPARK-9467][SQL]Add SQLMetric to specialize accumulators to avoid boxing #7996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @rxin |
|
Test build #40038 has finished for PR 7996 at commit
|
Contributor
There was a problem hiding this comment.
if i understand this correctly, this only works because the zero value of all these metrics are naturally 0 right?
(since we set zero value while we deserialize data)
Member
Author
There was a problem hiding this comment.
Right. I think we don't need a different initial value for SQL metrics. So just avoid to add an initial value to SQLMetricParam.
Contributor
|
LGTM |
|
Test build #40113 has finished for PR 7996 at commit
|
Member
Author
|
retest this please |
|
Test build #40126 has finished for PR 7996 at commit
|
|
Test build #1400 has finished for PR 7996 at commit
|
Contributor
|
Thanks - merging this in. |
asfgit
pushed a commit
that referenced
this pull request
Aug 7, 2015
…xing This PR adds SQLMetric/SQLMetricParam/SQLMetricValue to specialize accumulators to avoid boxing. All SQL metrics should use these classes rather than `Accumulator`. Author: zsxwing <[email protected]> Closes #7996 from zsxwing/sql-accu and squashes the following commits: 14a5f0a [zsxwing] Address comments 367ca23 [zsxwing] Use localValue directly to avoid changing Accumulable 42f50c3 [zsxwing] Add SQLMetric to specialize accumulators to avoid boxing (cherry picked from commit ebfd91c) Signed-off-by: Reynold Xin <[email protected]>
CodingCat
pushed a commit
to CodingCat/spark
that referenced
this pull request
Aug 17, 2015
…xing This PR adds SQLMetric/SQLMetricParam/SQLMetricValue to specialize accumulators to avoid boxing. All SQL metrics should use these classes rather than `Accumulator`. Author: zsxwing <[email protected]> Closes apache#7996 from zsxwing/sql-accu and squashes the following commits: 14a5f0a [zsxwing] Address comments 367ca23 [zsxwing] Use localValue directly to avoid changing Accumulable 42f50c3 [zsxwing] Add SQLMetric to specialize accumulators to avoid boxing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SQLMetric/SQLMetricParam/SQLMetricValue to specialize accumulators to avoid boxing. All SQL metrics should use these classes rather than
Accumulator.