Skip to content

[SPARK-9533] [PySpark] [ML] Add missing methods in Word2Vec ML #7930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MechCoder wants to merge 2 commits into from
Closed

[SPARK-9533] [PySpark] [ML] Add missing methods in Word2Vec ML #7930

MechCoder wants to merge 2 commits into from

Conversation

@MechCoder
Copy link
Contributor

@MechCoder MechCoder commented Aug 4, 2015

After #7263 it is pretty straightforward to Python wrappers.

@SparkQA
Copy link

SparkQA commented Aug 4, 2015

Test build #39700 has finished for PR 7930 at commit 5522756.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MechCoder
Copy link
Contributor Author

MechCoder commented Aug 4, 2015

retest this please

MechCoder
MechCoder reviewed Aug 4, 2015
View reviewed changes
mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala Outdated
Copy link
Contributor Author

@MechCoder MechCoder Aug 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkbradley this should be a def. Sorry that it went unnoticed by both of us.

Copy link
Member

@jkbradley jkbradley Aug 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, maybe both this and findSynonyms should be @transient lazy val.

@SparkQA
Copy link

SparkQA commented Aug 4, 2015

Test build #207 has finished for PR 7930 at commit 5522756.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 4, 2015

Test build #39711 has finished for PR 7930 at commit 5522756.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

jkbradley commented Aug 5, 2015

I'll make a pass now

@jkbradley
Copy link
Member

jkbradley commented Aug 5, 2015

Looks good except for maybe changing those Scala defs to transient lazy vals

@MechCoder
Copy link
Contributor Author

MechCoder commented Aug 6, 2015

@jkbradley Actally findSynonyms should be a method having parameters. Let me know if there is anything else.

@SparkQA
Copy link

SparkQA commented Aug 6, 2015

Test build #39999 has finished for PR 7930 at commit 1bea394.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

jkbradley commented Aug 6, 2015

LGTM, merging with master and branch-1.5
Thank you!

asfgit pushed a commit that referenced this pull request Aug 6, 2015
@MechCoder @jkbradley
[SPARK-9533] [PYSPARK] [ML] Add missing methods in Word2Vec ML
e24b976 
After #7263 it is pretty straightforward to Python wrappers.

Author: MechCoder <[email protected]>

Closes #7930 from MechCoder/spark-9533 and squashes the following commits:

1bea394 [MechCoder] make getVectors a lazy val
5522756 [MechCoder] [SPARK-9533] [PySpark] [ML] Add missing methods in Word2Vec ML

(cherry picked from commit 076ec05)
Signed-off-by: Joseph K. Bradley <[email protected]>
@asfgit asfgit closed this in 076ec05 Aug 6, 2015
@MechCoder MechCoder deleted the spark-9533 branch August 6, 2015 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MechCoder @SparkQA @jkbradley