Add a prerequisites section for building docs #7912
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks - merging. |
Member
There was a problem hiding this comment.
This is mostly redundant with existing docs below though ... ? delete one of them
Contributor
Author
There was a problem hiding this comment.
@rxin can probably add more, but I meant this to be redundant in the sense this section had a bunch of commands you could copy-paste while the succeeding sections had the rationale / breakdown of what was required when.
Member
There was a problem hiding this comment.
OK no problem. It's hardly a big deal; was more worrying about later updating one bit but not the other but, it's an ancillary doc that's not frequently updated.
Contributor
There was a problem hiding this comment.
I will reword README in a bit to make it more consistent.
asfgit
pushed a commit
that referenced
this pull request
Aug 5, 2015
This puts all the install commands that need to be run in one section instead of being spread over many paragraphs cc rxin Author: Shivaram Venkataraman <[email protected]> Closes #7912 from shivaram/docs-setup-readme and squashes the following commits: cf7a204 [Shivaram Venkataraman] Add a prerequisites section for building docs (cherry picked from commit 7abaaad) Signed-off-by: Reynold Xin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts all the install commands that need to be run in one section instead of being spread over many paragraphs
cc @rxin