[SPARK-9483] Fix UTF8String.getPrefix for big-endian. #7902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code assumed little-endian.
Contributor
|
/cc @davies |
Contributor
|
Jenkins, this is ok to test. |
Contributor
There was a problem hiding this comment.
can we move the result of ByteOrder.nativeOrder into a static variable?
Contributor
|
@mtbrandy not 100% sure, but it might be more clear if you just have a top level branch based on endianness. |
Contributor
Author
|
@rxin, regarding top-level branch -- I can do that, but was just trying to minimize duplicate code. |
Contributor
|
+1 for moving the endianness check to top level, otherwise LGTM. |
Contributor
Author
|
ok, I'll modify to move the endianness check up. |
- Introduce static byteOrder variable - Branch on byteOrder at top-level for readability.
|
Test build #39580 has finished for PR 7902 at commit
|
Contributor
|
@davies I will let you merge this. |
|
Test build #39589 has finished for PR 7902 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Aug 4, 2015
Previous code assumed little-endian. Author: Matthew Brandyberry <[email protected]> Closes #7902 from mtbrandy/SPARK-9483 and squashes the following commits: ec31df8 [Matthew Brandyberry] [SPARK-9483] Changes from review comments. 17d54c6 [Matthew Brandyberry] [SPARK-9483] Fix UTF8String.getPrefix for big-endian. (cherry picked from commit b79b4f5) Signed-off-by: Davies Liu <[email protected]>
Contributor
|
Merged into master and 1.5-branch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code assumed little-endian.