Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Jul 30, 2015

No description provided.

@rxin
Copy link
Contributor Author

rxin commented Jul 30, 2015

@mengxr I think this fixes the problem you ran into.

cc @cloud-fan

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be

ctx.references.foreach(_.foreach {
  case n: Nondeterministic => n.setInitialValues()
  case _ =>
})

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and why not do initiliaztion in CodegenFallback?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes

@rxin
Copy link
Contributor Author

rxin commented Jul 30, 2015

@cloud-fan updated.

@cloud-fan
Copy link
Contributor

lgtm

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #38956 has finished for PR 7767 at commit 713ac3a.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #38946 has finished for PR 7767 at commit bb5c334.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #38961 has finished for PR 7767 at commit ef3e2d9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in 27850af Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants