Skip to content

Conversation

@sthota2014
Copy link
Contributor

Went thru the history of changes the file MLUtils.scala and picked up the version that the change went in.

@mengxr
Copy link
Contributor

mengxr commented Jul 16, 2015

@sthota2014 You don't need to tag private or package private method. We only need @since on public methods.

@sthota2014
Copy link
Contributor Author

@mengxr Removed the @SInCE from the code for non-public methods.

@mengxr
Copy link
Contributor

mengxr commented Jul 17, 2015

ok to test

@SparkQA
Copy link

SparkQA commented Jul 17, 2015

Test build #37597 has finished for PR 7436 at commit 201e0fd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • * @deprecated("use method without multiclass argument, which no longer has effect", "1.1.0")
    • * @deprecated("use method without multiclass argument, which no longer has effect", "1.1.0")
    • * @deprecated("use method without multiclass argument, which no longer has effect", "1.1.0")

@sthota2014
Copy link
Contributor Author

@mengxr Any thoughts on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to leave the @deprecated outside the JavaDoc as a Scala annotation to make it work in Scala.

@SparkQA
Copy link

SparkQA commented Jul 23, 2015

Test build #38273 has finished for PR 7436 at commit 902d49b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • * @deprecated("use method without multiclass argument, which no longer has effect", "1.1.0")
    • * @deprecated("use method without multiclass argument, which no longer has effect", "1.1.0")

@sthota2014
Copy link
Contributor Author

@mengxr Any thoughts on this ?

@sthota2014
Copy link
Contributor Author

@mengxr can you please help me complete the cycle.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to keep this as an annotation. @deprecated in comments is a JavaDoc tag, while @deprecated outside comments is a Scala annotation, which helps generate compiler warnings.

We should keep each PR minimal, so please keep all @deprecated annotation unchanged.

@SparkQA
Copy link

SparkQA commented Aug 5, 2015

Test build #39905 has finished for PR 7436 at commit 865149c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sthota2014
Copy link
Contributor Author

@mengxr Any thoughts on this ?

asfgit pushed a commit that referenced this pull request Aug 11, 2015
Went thru the history of changes the file MLUtils.scala and picked up the version that the change went in.

Author: Sudhakar Thota <[email protected]>
Author: Sudhakar Thota <[email protected]>

Closes #7436 from sthota2014/SPARK-8925_thotas.

(cherry picked from commit 017b5de)
Signed-off-by: Xiangrui Meng <[email protected]>
@asfgit asfgit closed this in 017b5de Aug 11, 2015
@mengxr
Copy link
Contributor

mengxr commented Aug 11, 2015

LGTM. Merged into master and branch-1.5. Thanks!

@rxin
Copy link
Contributor

rxin commented Aug 11, 2015

How come the Jenkins run here didn't trigger test failures?

CodingCat pushed a commit to CodingCat/spark that referenced this pull request Aug 17, 2015
Went thru the history of changes the file MLUtils.scala and picked up the version that the change went in.

Author: Sudhakar Thota <[email protected]>
Author: Sudhakar Thota <[email protected]>

Closes apache#7436 from sthota2014/SPARK-8925_thotas.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants