-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-8925] [MLlib] Add @since tags to mllib.util #7436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sthota2014 You don't need to tag private or package private method. We only need |
|
ok to test |
|
Test build #37597 has finished for PR 7436 at commit
|
|
@mengxr Any thoughts on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to leave the @deprecated outside the JavaDoc as a Scala annotation to make it work in Scala.
|
Test build #38273 has finished for PR 7436 at commit
|
|
@mengxr Any thoughts on this ? |
|
@mengxr can you please help me complete the cycle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to keep this as an annotation. @deprecated in comments is a JavaDoc tag, while @deprecated outside comments is a Scala annotation, which helps generate compiler warnings.
We should keep each PR minimal, so please keep all @deprecated annotation unchanged.
|
Test build #39905 has finished for PR 7436 at commit
|
|
@mengxr Any thoughts on this ? |
Went thru the history of changes the file MLUtils.scala and picked up the version that the change went in. Author: Sudhakar Thota <[email protected]> Author: Sudhakar Thota <[email protected]> Closes #7436 from sthota2014/SPARK-8925_thotas. (cherry picked from commit 017b5de) Signed-off-by: Xiangrui Meng <[email protected]>
|
LGTM. Merged into master and branch-1.5. Thanks! |
|
How come the Jenkins run here didn't trigger test failures? |
Went thru the history of changes the file MLUtils.scala and picked up the version that the change went in. Author: Sudhakar Thota <[email protected]> Author: Sudhakar Thota <[email protected]> Closes apache#7436 from sthota2014/SPARK-8925_thotas.
Went thru the history of changes the file MLUtils.scala and picked up the version that the change went in.