Skip to content

[SPARK-8695][CORE][MLlib] TreeAggregation shouldn't be triggered when it doesn't save wall-clock time. #7397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
piganesh wants to merge 3 commits into from
Closed

[SPARK-8695][CORE][MLlib] TreeAggregation shouldn't be triggered when it doesn't save wall-clock time. #7397

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6fed07
[SPARK-8695] [core] [WIP] TreeAggregation shouldn't be triggered for …
piganesh Jul 1, 2015
9ad067c
[SPARK-8695] [core] [WIP] TreeAggregation shouldn't be triggered for …
piganesh Jul 14, 2015
041620c
[SPARK-8695][CORE][MLlib] TreeAggregation shouldn't be triggered when…
piganesh Jul 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/main/scala/org/apache/spark/rdd/RDD.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,9 @@ abstract class RDD[T: ClassTag](
val scale = math.max(math.ceil(math.pow(numPartitions, 1.0 / depth)).toInt, 2)
// If creating an extra level doesn't help reduce
// the wall-clock time, we stop tree aggregation.
while (numPartitions > scale + numPartitions / scale) {

// Don't trigger TreeAggregation when it doesn't save wall-clock time
while (numPartitions > scale + math.ceil((numPartitions).toDouble / scale)) {
Copy link
Member

@srowen srowen Jul 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the parens around (numPartitions) aren't needed. That's trivial though.

numPartitions /= scale
val curNumPartitions = numPartitions
partiallyAggregated = partiallyAggregated.mapPartitionsWithIndex {
Expand Down