Skip to content

[SPARK-8831][SQL] Support AbstractDataType in TypeCollection. #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rxin wants to merge 1 commit into from
Closed

[SPARK-8831][SQL] Support AbstractDataType in TypeCollection. #7232

rxin wants to merge 1 commit into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Jul 6, 2015

Otherwise it is impossible to declare an expression supporting DecimalType.

rxin
rxin reviewed Jul 6, 2015
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
Copy link
Contributor Author

@rxin rxin Jul 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @cloud-fan

@rxin
Copy link
Contributor Author

rxin commented Jul 6, 2015

cc @YijieSHEN I think you were looking for this in round?

@yjshen
Copy link
Member

yjshen commented Jul 6, 2015

Yep, just what I need :)

@cloud-fan
Copy link
Contributor

cloud-fan commented Jul 6, 2015

LGTM

@yjshen
Copy link
Member

yjshen commented Jul 6, 2015

Tried this out locally and works fine. LGTM as well.

@SparkQA
Copy link

SparkQA commented Jul 6, 2015

Test build #36558 has finished for PR 7232 at commit 934d3d1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Decode(bin: Expression, charset: Expression)

@rxin
Copy link
Contributor Author

rxin commented Jul 6, 2015

Thanks for looking at this. Going to merge it.

@asfgit asfgit closed this in 86768b7 Jul 6, 2015
@rxin rxin deleted the typecollection-adt branch July 6, 2015 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rxin @yjshen @cloud-fan @SparkQA