Skip to content

[SPARK-8784] [SQL] Add Python API for hex and unhex #7223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davies wants to merge 9 commits into from
Closed

[SPARK-8784] [SQL] Add Python API for hex and unhex #7223

davies wants to merge 9 commits into from

Conversation

@davies
Copy link
Contributor

@davies davies commented Jul 4, 2015

Add Python API for hex/unhex, also cleanup Hex/Unhex

Davies Liu added 7 commits July 2, 2015 00:03
Add Python API for hex and unhex
1a24082
address commments
c3af78c
address comments and fix test
25156b7
Update math.scala
b31fc9a
Merge branch 'master' of github.com:apache/spark into hex
49e325f 
Conflicts:
	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
	sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala
Merge branch 'hex' of github.com:davies/spark into hex
f032fbb
Merge branch 'master' of github.com:apache/spark into hex
f9fe5a3 
Conflicts:
	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
	sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
	sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala
@AmplabJenkins
Copy link

AmplabJenkins commented Jul 4, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 4, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented Jul 4, 2015

Test build #36535 has started for PR 7223 at commit f9fe5a3.

@SparkQA
Copy link

SparkQA commented Jul 4, 2015

Test build #36535 has finished for PR 7223 at commit f9fe5a3.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Hex(child: Expression) extends UnaryExpression with ExpectsInputTypes
    • case class Unhex(child: Expression) extends UnaryExpression with ExpectsInputTypes
    • case class ShiftLeft(left: Expression, right: Expression)
    • case class ShiftRight(left: Expression, right: Expression)
    • case class ShiftRightUnsigned(left: Expression, right: Expression)

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 4, 2015

Merged build finished. Test FAILed.

@davies
Copy link
Contributor Author

davies commented Jul 4, 2015

cc @rxin

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 4, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 4, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented Jul 4, 2015

Test build #36536 has started for PR 7223 at commit 711a6ed.

@SparkQA
Copy link

SparkQA commented Jul 4, 2015

Test build #36536 has finished for PR 7223 at commit 711a6ed.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Hex(child: Expression) extends UnaryExpression with ExpectsInputTypes
    • case class Unhex(child: Expression) extends UnaryExpression with ExpectsInputTypes
    • case class ShiftLeft(left: Expression, right: Expression)
    • case class ShiftRight(left: Expression, right: Expression)
    • case class ShiftRightUnsigned(left: Expression, right: Expression)

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 4, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 6, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 6, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented Jul 6, 2015

Test build #36582 has started for PR 7223 at commit 6f1249d.

@SparkQA
Copy link

SparkQA commented Jul 6, 2015

Test build #36582 has finished for PR 7223 at commit 6f1249d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Unhex(child: Expression) extends UnaryExpression with ExpectsInputTypes

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 6, 2015

Merged build finished. Test PASSed.

@rxin
Copy link
Contributor

rxin commented Jul 6, 2015

LGTM.

@rxin
Copy link
Contributor

rxin commented Jul 6, 2015

(although asf infra is down so we cannot merge anything)

@asfgit asfgit closed this in 37e4d92 Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davies @AmplabJenkins @SparkQA @rxin