-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-8549][SparkR] Fix the line length of SparkR #7204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #36462 has finished for PR 7204 at commit
|
|
@shivaram Could you review this PR when you have time? Thanks! |
R/pkg/R/utils.R
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we call this storageLevelClass ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It is a just string variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but the variable name spelling is strange right now as strage -- could you make the variable name storage instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that. I got it.
|
Test build #36471 has finished for PR 7204 at commit
|
|
Thanks @yu-iskw -- Just for my information can you paste a link to output of |
|
@shivaram , Sure. That is the result of |
|
Thanks @yu-iskw. BTW We should investigate how to get rid of the false warnings But this change LGTM. Merging this |
|
@shivaram Thank you for merging it! |
|
@yu-iskw you might want to update your github email to include the email address you used for your commits. Otherwise it doesn't show up in the github metadata. |
|
@rxin Thank you for letting me know. I have updated my github email in my account profile. |
[SPARK-8549] Fix the line length of SparkR - ASF JIRA