-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-8482] Added M4 instances to the list. #6899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark |
|
@srowen I created a JIRA ticket and updated the title with that. |
|
We might as well include the new T2.large instance while we're at it: https://aws.amazon.com/blogs/aws/new-t2-large-instances/ |
|
@JoshRosen Thank you for reminding it. Added t2.large as well. |
|
Jenkins, this is ok to test. (So the Python style checks are run) |
|
Jenkins, this is ok to test. |
|
Test build #35354 has finished for PR 6899 at commit
|
|
Jenkins, retest this please. |
|
(Retesting to test a build script change) |
|
Test build #35374 has finished for PR 6899 at commit
|
|
Merged build finished. Test FAILed. |
|
@davies @ahirreddy The tests here passed, but the test-selection logic was too good: by skipping all of the Scala / Java tests, we didn't write any JUnit XML files, causing Jenkins to mark the build as failed. Maybe we should just add a dummy XML file to the build / repo to avoid this (or see if we can somehow configure the Jenkins plugin to be more permissive w.r.t missing report files (the artifact upload plugin is robust against this, for example)). |
|
LGTM. This is safe to commit in that there was no actual test failure due to this right? |
|
Yeah it should be fine to commit; go ahead. Sent from my phone
|
|
Merging this |
AWS recently added M4 instances (https://aws.amazon.com/blogs/aws/the-new-m4-instance-type-bonus-price-reduction-on-m3-c4/). Author: Pradeep Chhetri <[email protected]> Closes apache#6899 from pradeepchhetri/master and squashes the following commits: 4f4ea79 [Pradeep Chhetri] Added t2.large instance 3d2bb6c [Pradeep Chhetri] Added M4 instances to the list
AWS recently added M4 instances (https://aws.amazon.com/blogs/aws/the-new-m4-instance-type-bonus-price-reduction-on-m3-c4/).