Skip to content

Conversation

@pradeepchhetri
Copy link
Contributor

@srowen
Copy link
Member

srowen commented Jun 19, 2015

@pradeepchhetri pradeepchhetri changed the title Added M4 instances to the list. [SPARK-8482] Added M4 instances to the list. Jun 19, 2015
@pradeepchhetri
Copy link
Contributor Author

@srowen I created a JIRA ticket and updated the title with that.

@JoshRosen
Copy link
Contributor

We might as well include the new T2.large instance while we're at it: https://aws.amazon.com/blogs/aws/new-t2-large-instances/

@pradeepchhetri
Copy link
Contributor Author

@JoshRosen Thank you for reminding it. Added t2.large as well.

@JoshRosen
Copy link
Contributor

Jenkins, this is ok to test.

(So the Python style checks are run)

@JoshRosen
Copy link
Contributor

Jenkins, this is ok to test.

@SparkQA
Copy link

SparkQA commented Jun 20, 2015

Test build #35354 has finished for PR 6899 at commit 4f4ea79.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

Jenkins, retest this please.

@JoshRosen
Copy link
Contributor

(Retesting to test a build script change)

@SparkQA
Copy link

SparkQA commented Jun 20, 2015

Test build #35374 has finished for PR 6899 at commit 4f4ea79.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@JoshRosen
Copy link
Contributor

@davies @ahirreddy The tests here passed, but the test-selection logic was too good: by skipping all of the Scala / Java tests, we didn't write any JUnit XML files, causing Jenkins to mark the build as failed. Maybe we should just add a dummy XML file to the build / repo to avoid this (or see if we can somehow configure the Jenkins plugin to be more permissive w.r.t missing report files (the artifact upload plugin is robust against this, for example)).

@srowen
Copy link
Member

srowen commented Jun 22, 2015

LGTM. This is safe to commit in that there was no actual test failure due to this right?

@JoshRosen
Copy link
Contributor

Yeah it should be fine to commit; go ahead.

Sent from my phone

On Jun 22, 2015, at 1:25 AM, Sean Owen [email protected] wrote:

LGTM. This is safe to commit in that there was no actual test failure due to this right?


Reply to this email directly or view it on GitHub.

@shivaram
Copy link
Contributor

Merging this

@asfgit asfgit closed this in ba8a453 Jun 22, 2015
animeshbaranawal pushed a commit to animeshbaranawal/spark that referenced this pull request Jun 25, 2015
AWS recently added M4 instances (https://aws.amazon.com/blogs/aws/the-new-m4-instance-type-bonus-price-reduction-on-m3-c4/).

Author: Pradeep Chhetri <[email protected]>

Closes apache#6899 from pradeepchhetri/master and squashes the following commits:

4f4ea79 [Pradeep Chhetri] Added t2.large instance
3d2bb6c [Pradeep Chhetri] Added M4 instances to the list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants