Skip to content

[SPARK-8349][SQL] Use expression constructors (rather than apply) in FunctionRegistry #6806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rxin wants to merge 2 commits into from
Closed

[SPARK-8349][SQL] Use expression constructors (rather than apply) in FunctionRegistry #6806

rxin wants to merge 2 commits into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Jun 13, 2015

No description provided.

@SparkQA
Copy link

SparkQA commented Jun 13, 2015

Test build #34852 has finished for PR 6806 at commit c7fc3e6.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 14, 2015

Test build #34853 has finished for PR 6806 at commit ed1aebb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

marmbrus
marmbrus reviewed Jun 14, 2015
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
Copy link
Contributor

@marmbrus marmbrus Jun 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

val f = try tag.runtimeClass.getDeclaredConstructor(params: _*) catch {
  case _: NoSuchMethodError =>
    throw new AnalysisException(s"Invalid number of arguments for function $name")
}

😄

@asfgit asfgit closed this in 2d71ba4 Jun 14, 2015
@rxin rxin mentioned this pull request Jun 14, 2015
Closed
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@rxin @nemccarthy
[SPARK-8349] [SQL] Use expression constructors (rather than apply) in…
e1c5f49 
… FunctionRegistry

Author: Reynold Xin <[email protected]>

Closes apache#6806 from rxin/gs and squashes the following commits:

ed1aebb [Reynold Xin] Fixed style.
c7fc3e6 [Reynold Xin] [SPARK-8349][SQL] Use expression constructors (rather than apply) in FunctionRegistry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rxin @SparkQA @marmbrus