[Spark-7780][MLLIB] Intercept in logisticregressionwith lbfgs should not be regularized no round trip through data frames#6771
Closed
holdenk wants to merge 23 commits intoapache:masterfrom
Conversation
…n 2 we use the legacy implementation. Also allow pass through of initialWeights
…ctors instead of keeping track of class variable, pass through persistence information
…om tests require that feature scaling is turned on to use ml implementation.
…with the weights when they are user supploed, validate that the user supplied weights are reasonable.
…itting an intercept from mllib to ml when training lbfgs model using ml code
|
Test build #34731 has finished for PR 6771 at commit
|
Contributor
Author
|
re-opening for @dbtsai to review - I'll update it some more tonight / tomorrow to be closer to master. |
…eledpoints is a little painful as is the summary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is similar to #6386 but avoids the round trip through dataframes. On the other hand it might be a little less clean.