Skip to content

[SPARK-8158] [SQL] several fix for HiveShim #6700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-8158] [SQL] several fix for HiveShim #6700

wants to merge 1 commit into from

Conversation

@adrian-wang
Copy link
Contributor

@adrian-wang adrian-wang commented Jun 8, 2015

  1. explicitly import implicit conversion support.
  2. use .nonEmpty instead of .size > 0
  3. use val instead of var
  4. comment indention

@rxin
Copy link
Contributor

rxin commented Jun 8, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Jun 8, 2015

Test build #34415 has finished for PR 6700 at commit d22e108.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@adrian-wang
Copy link
Contributor Author

adrian-wang commented Jun 8, 2015

retest this please.

@SparkQA
Copy link

SparkQA commented Jun 8, 2015

Test build #34424 timed out for PR 6700 at commit d22e108 after a configured wait of 175m.

@adrian-wang
Copy link
Contributor Author

adrian-wang commented Jun 8, 2015

retest this please.

@vanzin
Copy link
Contributor

vanzin commented Jun 8, 2015

#6604?

@SparkQA
Copy link

SparkQA commented Jun 8, 2015

Test build #34448 has finished for PR 6700 at commit d22e108.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jun 8, 2015

I've merged this. Thanks.

@asfgit asfgit closed this in ed5c2dc Jun 8, 2015
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@adrian-wang @nemccarthy
[SPARK-8158] [SQL] several fix for HiveShim
56a54cc 
1. explicitly import implicit conversion support.
2. use .nonEmpty instead of .size > 0
3. use val instead of var
4. comment indention

Author: Daoyuan Wang <[email protected]>

Closes apache#6700 from adrian-wang/shimsimprove and squashes the following commits:

d22e108 [Daoyuan Wang] several fix for HiveShim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adrian-wang @rxin @SparkQA @vanzin