Skip to content

[SPARK-7863][Core] Create SimpleDateFormat for every SimpleDateParam instance because it's not thread-safe #6406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zsxwing wants to merge 3 commits into from
Closed

[SPARK-7863][Core] Create SimpleDateFormat for every SimpleDateParam instance because it's not thread-safe #6406

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9680a15
Create SimpleDateFormat for each SimpleDateParam instance because it'…
zsxwing May 26, 2015
8cdd986
Inline formats
zsxwing May 26, 2015
aeed4c1
Rewrite SimpleDateParam
zsxwing May 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 12 additions & 15 deletions core/src/main/scala/org/apache/spark/status/api/v1/SimpleDateParam.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,19 @@ import javax.ws.rs.core.Response.Status
import scala.util.Try

private[v1] class SimpleDateParam(val originalValue: String) {

private val formats: Seq[SimpleDateFormat] = {

@srowen srowen May 26, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this is a field though. There's no need for that. The format objects can be created on demand to parse the input. If this SimpleDateParam object is short-lived I suppose it does not matter much but I would have just inlined all this.

@zsxwing zsxwing May 26, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inlined formats.

val gmtDay = new SimpleDateFormat("yyyy-MM-dd")
gmtDay.setTimeZone(TimeZone.getTimeZone("GMT"))

Seq(
new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSz"),
gmtDay
)
}

val timestamp: Long = {
SimpleDateParam.formats.collectFirst {
formats.collectFirst {
case fmt if Try(fmt.parse(originalValue)).isSuccess =>
fmt.parse(originalValue).getTime()
}.getOrElse(
Expand All @@ -39,17 +50,3 @@ private[v1] class SimpleDateParam(val originalValue: String) {
)
}
}

private[v1] object SimpleDateParam {

val formats: Seq[SimpleDateFormat] = {

val gmtDay = new SimpleDateFormat("yyyy-MM-dd")
gmtDay.setTimeZone(TimeZone.getTimeZone("GMT"))

Seq(
new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSz"),
gmtDay
)
}
}